JSON:API 1.1: return empty 'included' array when ?include= is present

[harshalkalewar]

Fixes #1109

This PR fixes handling of the included array so that it correctly respects both JSONAPIMeta.included_resources defaults and explicit include query parameters.

Description of the Change

• Simplified the renderers.py logic to handle empty included arrays correctly using if included_resources:.
• Added and adjusted test cases in test_includes.py to verify:
• Updated failing test_search_keywords to expect an empty included array in line with default includes

Checklist

• PR only contains one change (considered splitting up PR)
• unit-test added
• documentation updated
• CHANGELOG.md updated (only for user relevant changes)
• author name in AUTHORS

[harshalkalewar]

Fixed tox lint config issue. Also, verified locally with tox -e lint and all checks passing.

[sliverc]

Thanks for working on this PR.

I would recommend being careful when you use AI. Always verify what it does, before accepting it.

For instance the pull request template and its checklist is actually made for human beings and not AI.

In the checklist it states to add changelog entry and add yourself to authors. Great if you could follow up on those.

Let me know if you have any questions.

[harshalkalewar]

Thanks for the feedback @sliverc. I’ll make sure to review my changes instead of relying on AI.
Regarding the failing test i.e. test_search_keywords, i noticed it fails because included: [] is now always present. should i update the test to match this new behavior, or should i adjust the implementation to keep the previous behavior?

[sliverc]

Thanks for following up. You need to adjust the test_search_keywords test because this test relies on a view which has default included resources, so there should be an empty-included array.

[harshalkalewar]

@sliverc you can let me know if you expect any changes to be made further.

[sliverc]

There were some not necessary new lines added which I reverted, it looks good now and ready for merging. Thanks for your work on this.

[harshalkalewar]

@sliverc thanks for helping me make my first open source contribution! Looking forward to connect with you linkedin.