Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where modal styles were not being properly cleaned up when a modal was destroyed. The fix involves enhancing the modal disposal logic to ensure the backdrop animation is disabled and the modal is hidden before disposal if the 'modal-open' class is present on the body. Additionally, the project version has been updated. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to explain why
dialog._hideModal()is being called directly.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5538 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5537
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]
Summary By Copilot
This pull request includes a version update and an enhancement to the modal disposal logic in the
BootstrapBlazorproject. The most important changes are:Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the version from9.4.7-beta01to9.4.7-beta02.Enhancement to modal disposal:
src/BootstrapBlazor/Components/Modal/Modal.razor.js: Improved the modal disposal logic by ensuring that the backdrop animation is disabled and the modal is hidden before disposal if themodal-openclass is present on the body.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: