refactor(Modal): add back/restoreBodyStyle function#5544
Merged
Conversation
# Conflicts: # src/BootstrapBlazor/Components/Modal/Modal.razor.js
Contributor
Reviewer's Guide by SourceryThis pull request refactors the Sequence diagram for hiding the modalsequenceDiagram
participant document
participant modal
document->>modal: modal.hide()
activate modal
modal->>modal: modal.modal.hide()
modal->>modal: restoreBodyStyle(modal)
alt modal.originalStyle is defined
modal->>document: document.body.style.cssText = modal.originalStyle
modal->>modal: delete modal.originalStyle
end
modal->>modal: invoke.invokeMethodAsync(modal.closeCallback)
deactivate modal
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding comments to the helper functions to explain their purpose.
- It might be clearer to use
modal.originalStyle === undefinedinstead ofmodal.originalStyle ??= ...andmodal.originalStyle !== undefinedinstead ofmodal.originalStyle.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5544 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5543
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]
Summary By Copilot
This pull request includes refactoring of the
Modalcomponent insrc/BootstrapBlazor/Components/Modal/Modal.razor.jsto improve the handling of the document body style when showing and hiding modals. The most important changes include the introduction of helper functions to backup and restore the body style.Refactoring of modal body style handling:
src/BootstrapBlazor/Components/Modal/Modal.razor.js: Replaced inline style backup and restore logic withbackupBodyStyleandrestoreBodyStylehelper functions inmodal.show,modal.hide, anddisposefunctions. [1] [2] [3]backupBodyStylefunction to store the original body style inmodal.originalStyleif it is not already set.restoreBodyStylefunction to revert the body style to the original and deletemodal.originalStyleif it is set.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: