refactor(ThemeMode): update view-transition style

[ArgoZhang]

Link issues

fixes #5579

Summary By Copilot

This pull request includes several changes to the BootstrapBlazor project, focusing on theme management and animation improvements. The most important changes involve adding a new function to calculate the center position of an element, updating theme switching logic to use this function, and enhancing CSS animations for view transitions.

Theme Management Updates:

• src/BootstrapBlazor.Server/Components/Components/ThemeMode.razor.js: Added calcCenterPosition function import and updated switchTheme to use element center coordinates. [1] [2]
• src/BootstrapBlazor/Components/ThemeProvider/ThemeProvider.razor.js: Added calcCenterPosition function import and updated switchTheme to use element center coordinates. [1] [2]

Utility Function Addition:

• src/BootstrapBlazor/wwwroot/modules/utility.js: Added calcCenterPosition function to calculate the center position of an element.

CSS Animation Enhancements:

• src/BootstrapBlazor/wwwroot/scss/root.scss: Updated view transition animations and added keyframes for clip and clip2 animations, improving theme transition effects. [1] [2]

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Updates the theme switching logic to use the center coordinates of the element and enhances CSS animations for view transitions.

Enhancements:

• Updates theme switching logic to use the center coordinates of the element.
• Enhances CSS animations for view transitions by adding keyframes for clip and clip2 animations.
• Adds a utility function to calculate the center position of an element.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the theme switching mechanism by introducing a utility function to calculate the center position of elements, updating the theme switching logic to utilize this function, and enhancing the CSS animations for smoother and more visually appealing view transitions, particularly when switching to and from dark mode.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a utility function to calculate the center position of an element.	Added calcCenterPosition function to utility.js.	src/BootstrapBlazor/wwwroot/modules/utility.js
Updated theme switching logic to use the calculated center position for improved animation effects.	Imported calcCenterPosition in ThemeMode.razor.js and ThemeProvider.razor.js. Modified switchTheme calls in ThemeMode.razor.js and ThemeProvider.razor.js to pass the element's center coordinates. Removed passing window dimensions to the switchTheme function.	src/BootstrapBlazor.Server/Components/Components/ThemeMode.razor.js src/BootstrapBlazor/Components/ThemeProvider/ThemeProvider.razor.js
Enhanced CSS animations for view transitions, including specific animations for dark mode.	Updated view transition styles for old and new elements. Added clip and clip2 keyframe animations for theme transitions. Defined specific animations for dark mode transitions using clip2.	src/BootstrapBlazor/wwwroot/scss/root.scss

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5579	Update the view-transition style for theme changes.	✅

Possibly linked issues

• refactor(ThemeMode): update view-transition style #5579: The PR implements the changes described in the issue by updating CSS animations for view transitions.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider consolidating the duplicated theme switching logic in ThemeMode.razor.js and ThemeProvider.razor.js into a shared function.
• The CSS animation changes look good, but it would be helpful to have a visual example or demo to showcase the improvements.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}