feat(TreeViewToolbarEditButton): add Icon parameter#5647
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a demo to showcase the new
Iconparameter in the TreeViewToolbarEditButton component.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 653 653
Lines 29387 29393 +6
Branches 4194 4195 +1
=========================================
+ Hits 29387 29393 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5646
Summary By Copilot
This pull request includes updates to the
BootstrapBlazorproject, focusing on adding a new icon for theTreeViewToolbarEditButtoncomponent and updating its related files accordingly. The most important changes include modifying the project version, adding a newIconparameter, and updating the icon mappings for different icon themes.Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated project version from9.4.9to9.5.0-beta01.Component Enhancements:
src/BootstrapBlazor/Components/TreeView/TreeViewToolbarEditButton.razor: Modified theIconproperty in thePopConfirmButtonto use the newIconparameter.src/BootstrapBlazor/Components/TreeView/TreeViewToolbarEditButton.razor.cs: Added a newIconparameter and injected theIIconThemeservice to set a default icon if none is provided. [1] [2]Icon Theme Updates:
src/BootstrapBlazor/Enums/ComponentIcons.cs: Added a new enum valueTreeViewToolbarEditButtonfor the new icon.src/BootstrapBlazor/Icons/BootstrapIcons.cs: Mapped the newTreeViewToolbarEditButtonicon to "bi bi-check2-square".src/BootstrapBlazor/Icons/FontAwesomeIcons.cs: Mapped the newTreeViewToolbarEditButtonicon to "fa-regular fa-pen-to-square".src/BootstrapBlazor/Icons/MaterialDesignIcons.cs: Mapped the newTreeViewToolbarEditButtonicon to "mdi mdi-file-edit-outline".Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds an Icon parameter to the TreeViewToolbarEditButton component, allowing developers to customize the edit button's icon.
Enhancements: