Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces a Sequence diagram for rendering a chat message with MarkdownContentsequenceDiagram
participant Chats.razor
participant MarkdownContent
Chats.razor->>MarkdownContent: Renders MarkdownContent with message.Content
activate MarkdownContent
MarkdownContent->>MarkdownContent: OnParametersSet()
MarkdownContent->>MarkdownContent: GetMarkdown(message.Content)
MarkdownContent->>MarkdownContent: HandleUnclosedThinkTags(message.Content)
MarkdownContent->>MarkdownContent: RemoveEmbeddingsElement(message.Content)
MarkdownContent->>MarkdownContent: Markdown.ToHtml(message.Content, markdownPipeline)
MarkdownContent-->>Chats.razor: Returns HTML
deactivate MarkdownContent
Chats.razor->>Browser: Displays rendered HTML
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @MadLongTom. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Hey @MadLongTom - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the markdown pipeline configuration to a static field for reuse.
- The HandleUnclosedThinkTags method could be simplified by using a single Regex.Replace with a more complex pattern.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5653 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29926 29926
Branches 4248 4248
=========================================
Hits 29926 29926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArgoZhang
previously approved these changes
Mar 29, 2025
…nt.razor Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: MadLongTom <36219016+MadLongTom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5753
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds support for Deepseek by introducing a new MarkdownContent component for rendering chat messages.
New Features: