feat(Calendar): add FirstDayOfWeek parameter#5692
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify the
FirstDayOfWeekfunctionality. - The project version downgrade seems unusual; please confirm this was intentional.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5692 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29770 29776 +6
Branches 4220 4220
=========================================
+ Hits 29770 29776 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5689
Summary By Copilot
This pull request introduces several changes across multiple files to add the
FirstDayOfWeekparameter to theCalendarandDateTimePickercomponents, along with corresponding localization updates. Additionally, there are minor adjustments to the project version and the method of generating week lists.Key Changes:
New Feature:
FirstDayOfWeekParametersrc/BootstrapBlazor.Server/Components/Samples/Calendars.razor: AddedFirstDayOfWeekparameter to theCalendarcomponent.src/BootstrapBlazor.Server/Components/Samples/Calendars.razor.cs: UpdatedGetAttributesmethod to includeFirstDayOfWeekattribute forCalendar.src/BootstrapBlazor.Server/Components/Samples/DateTimePickers.razor.cs: UpdatedGetAttributesmethod to includeFirstDayOfWeekattribute forDateTimePicker.src/BootstrapBlazor/Components/Calendar/Calendar.razor.cs: AddedFirstDayOfWeekparameter and modifiedStartDateandGetWeekListmethods to respect this parameter. [1] [2] [3] [4]src/BootstrapBlazor/Components/DateTimePicker/DatePickerBody.razor.cs: UpdatedGetWeekListmethod to use the new list slicing syntax.Localization Updates
src/BootstrapBlazor.Server/Locales/en-US.json: Added localization entries forFirstDayOfWeekandAttrFirstDayOfWeek. [1] [2]src/BootstrapBlazor.Server/Locales/zh-CN.json: Added localization entries forFirstDayOfWeekandAttrFirstDayOfWeek. [1] [2]Project Version Update
src/BootstrapBlazor/BootstrapBlazor.csproj: Downgraded project version from9.5.0-beta11to9.4.11.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: