refactor(Table): throw exception when set IsTree to true in virtualize mode#5723
Merged
refactor(Table): throw exception when set IsTree to true in virtualize mode#5723
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces a check to prevent the use of virtual scrolling in tree mode in the Updated class diagram for the Table componentclassDiagram
class Table {
ScrollMode ScrollMode
bool IsTree
OnParametersSet()
}
note for Table "Throws InvalidOperationException if ScrollMode is Virtual and IsTree is true"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the exception throwing logic into a separate method for better readability.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5723 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29829 29832 +3
Branches 4229 4230 +1
=========================================
+ Hits 29829 29832 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5722
fixes #5685
Summary By Copilot
This pull request introduces a check to prevent the use of virtual scrolling in tree mode in the
Tablecomponent and updates the corresponding unit tests to validate this behavior.Changes to
Tablecomponent:OnParametersSetmethod to throw anInvalidOperationExceptionifScrollModeis set toVirtualandIsTreeistrue. (src/BootstrapBlazor/Components/Table/Table.razor.cs)Changes to unit tests:
ScrollMode_Oktest to prevent unnecessary logs during test execution. (test/UnitTest/Components/TableTest.cs)InvalidOperationExceptionis thrown whenIsTreeis set totruewhileScrollModeisVirtual. (test/UnitTest/Components/TableTest.cs)Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Prevent using virtual scrolling with tree mode in Table component by adding a validation check that throws an exception when incompatible settings are configured
Bug Fixes:
Tests: