feat(Watermark): add data-bb-watermark attribute

[ArgoZhang]

Link issues

fixes #5824

Summary By Copilot

This pull request includes several changes to the src/BootstrapBlazor/Components/Watermark/Watermark.razor.js file, focusing on improving the watermark management functionality. The most important changes include adding the el attribute to the watermark object, modifying the watermark creation process to handle page-level watermarks, and enhancing the cleanup process to ensure proper removal of watermark elements.

Enhancements to watermark management:

• src/BootstrapBlazor/Components/Watermark/Watermark.razor.js: Added the el attribute to the watermark object and ensured it is properly removed during the disposal process.
• src/BootstrapBlazor/Components/Watermark/Watermark.razor.js: Modified the watermark creation process to set a data attribute on the body element and append the watermark element for page-level watermarks.
• src/BootstrapBlazor/Components/Watermark/Watermark.razor.js: Enhanced the clearWatermark function to check for the existence of el and ob before attempting to clear and disconnect them.

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Enhance watermark functionality by adding a data attribute and improving watermark management for page-level and element-specific watermarks

New Features:

• Add data-bb-watermark attribute to support page-level watermark identification

Bug Fixes:

• Ensure proper removal of watermark elements during disposal
• Add null checks when clearing watermarks to prevent potential errors

Enhancements:

• Improve watermark disposal and cleanup process
• Modify watermark creation to support both page-level and element-specific watermarks

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the Watermark.razor.js file to improve watermark management. It adds an el attribute to the watermark object, modifies the watermark creation process to handle page-level watermarks by setting a data-bb-watermark attribute on the body, and enhances the cleanup process to ensure proper removal of watermark elements by checking for the existence of el and ob before clearing and disconnecting them.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added the el attribute to the watermark object and ensured it is properly removed during the disposal process.	Added the el attribute to the watermark object. Ensured the el attribute is properly removed during the disposal process. Removed the data-bb-watermark attribute from the body during disposal.	src/BootstrapBlazor/Components/Watermark/Watermark.razor.js
Modified the watermark creation process to handle page-level watermarks.	Set a data attribute on the body element for page-level watermarks. Appended the watermark element to the body for page-level watermarks.	src/BootstrapBlazor/Components/Watermark/Watermark.razor.js
Enhanced the clearWatermark function to check for the existence of el and ob before attempting to clear and disconnect them.	Added a check for the existence of ob before disconnecting it. Added a check for the existence of el before clearing its inner HTML.	src/BootstrapBlazor/Components/Watermark/Watermark.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5824	Add a data-bb-watermark attribute to the body element when a page-level watermark is active.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/BootstrapBlazor/Components/Watermark/Watermark.razor.js:109

• [nitpick] The diff replaces the previous bg.isPage check with options.isPage. Consider unifying the naming convention (perhaps using one consistent property) to improve clarity on how the page-level watermark is determined.

if (options.isPage) {

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a check for watermark in the dispose function before accessing its properties to avoid potential errors.
• It might be good to add a check to see if the attribute data-bb-watermark exists before attempting to remove it.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e2e2b9) to head (33128c9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5825   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          660       660           
  Lines        30136     30136           
  Branches      4253      4253           
=========================================
  Hits         30136     30136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.