feat(IVideoDevice): add IVideoDevice service#5940
Merged
Conversation
Contributor
Reviewer's GuideThis pull request introduces services ( File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Consider separating media device enumeration logic from media stream control logic (open/close/capture) into distinct services.
- Passing DOM selectors from C# services to JavaScript tightly couples the service logic to specific UI implementations.
- Remove the empty
DisplayMediaOptionsandMediaStreamclasses if they are placeholders for future work.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+30
to
+31
| const stream = await navigator.mediaDevices.getUserMedia(constrains); | ||
| video.srcObject = stream; |
Contributor
There was a problem hiding this comment.
suggestion (bug_risk): Consider handling errors in open() function.
Wrap the navigator.mediaDevices.getUserMedia call in a try-catch to handle permission denials and other errors gracefully.
Suggested change
| const stream = await navigator.mediaDevices.getUserMedia(constrains); | |
| video.srcObject = stream; | |
| try { | |
| const stream = await navigator.mediaDevices.getUserMedia(constrains); | |
| video.srcObject = stream; | |
| } catch (error) { | |
| console.error("Error accessing media devices:", error); | |
| } |
| } | ||
| } | ||
|
|
||
| export async function capture(videoSelector) { |
Contributor
There was a problem hiding this comment.
suggestion (bug_risk): Check for existence of target element in capture().
Ensure document.querySelector('.b-video-image') returns a non-null element before use to avoid runtime errors.
Suggested implementation:
export async function capture(videoSelector) {
const video = document.querySelector(videoSelector);
if (video) {
const bVideoImage = document.querySelector('.b-video-image');
if (!bVideoImage) {
console.error("The element with class 'b-video-image' was not found.");
return;
}If the capture() function uses the bVideoImage element later to display a captured image, ensure that further logic (e.g., drawing from a canvas and setting bVideoImage.src) is placed after this check.
|
|
||
| class DefaultMediaDevices(IJSRuntime jsRuntime) : IMediaDevices | ||
| { | ||
| private DotNetObjectReference<DefaultMediaDevices>? _interop = null; |
Contributor
There was a problem hiding this comment.
suggestion (bug_risk): Dispose DotNetObjectReference to prevent memory leaks.
Implement IAsyncDisposable (or manually dispose) to release the _interop DotNetObjectReference created in LoadModule when the service is disposed.
Suggested implementation:
class DefaultMediaDevices(IJSRuntime jsRuntime) : IMediaDevices, IAsyncDisposable private DotNetObjectReference<DefaultMediaDevices>? _interop = null; // ... existing code ... private async Task<JSModule> LoadModule()
{
_interop ??= DotNetObjectReference.Create(this); // Other existing methods...
public async ValueTask DisposeAsync()
{
if (_module is not null)
{
await _module.DisposeAsync();
_module = null;
}
if (_interop is not null)
{
_interop.Dispose();
_interop = null;
}
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5940 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 665 669 +4
Lines 30485 30551 +66
Branches 4345 4347 +2
=========================================
+ Hits 30485 30551 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Vincent <142959771+vincent8725@users.noreply.github.com>
ArgoZhang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5939
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add media device support to the BootstrapBlazor library, introducing services and components for interacting with media devices like cameras
New Features:
Enhancements: