bug(FullScreenService): sync fullscreen state with esc key event

[ArgoZhang]

Link issues

fixes #5960

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Improve fullscreen functionality by synchronizing fullscreen state and updating UI handling for fullscreen events

Bug Fixes:

• Fixed fullscreen state synchronization with browser fullscreen events

Enhancements:

• Simplified fullscreen state management in JavaScript
• Updated CSS to handle fullscreen state more robustly

Chores:

• Updated deprecation message for FullScreenIcon parameter

[sourcery-ai]

Reviewer's Guide

This pull request refactors the fullscreen state synchronization by removing the JavaScript-managed .bb-fs-open class and instead utilizes the browser's native :fullscreen CSS pseudo-class to control the button's icon state and related styles.

Sequence diagram for updated fullscreen toggle

sequenceDiagram
    actor User
    participant Browser
    participant FullScreenButton
    participant fullscreen.js

    User->>FullScreenButton: Click
    FullScreenButton->>fullscreen.js: toggle()
    alt Enter Fullscreen
        fullscreen.js->>Browser: requestFullscreen()
        Browser-->>CSS: Apply ':fullscreen' styles
    else Exit Fullscreen
        fullscreen.js->>Browser: exitFullscreen()
        Browser-->>CSS: Remove ':fullscreen' styles
    end

    User->>Browser: Press ESC key
    Browser-->>CSS: Remove ':fullscreen' styles

Loading

File-Level Changes

Change	Details	Files
Replaced JavaScript-based fullscreen state management with CSS :fullscreen pseudo-class.	Removed updateFullscreenState function and .bb-fs-open class toggling from JavaScript. Updated FullScreenButton.razor.scss to use :fullscreen pseudo-class for icon display. Removed styles dependent on .bb-fs-open from Tab.razor.scss.	src/BootstrapBlazor/Components/FullScreen/FullScreenButton.razor.scss src/BootstrapBlazor/wwwroot/modules/fullscreen.js src/BootstrapBlazor/Components/Tab/Tab.razor.scss
Updated obsolete message text.	Clarified the Obsolete attribute message for the FullScreenIcon parameter.	src/BootstrapBlazor/Components/FullScreen/FullScreenButton.razor.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5960	Synchronize the fullscreen state with the Escape key event.	✅

Possibly linked issues

• bug(FullScreenService): sync fullscreen state with esc key event #5960: The PR fixes issue bug(FullScreenService): sync fullscreen state with esc key event #5960 by removing manual state updates and using the native :fullscreen pseudo-class to sync fullscreen state, addressing the escape key issue.
• bug(FullScreenService): sync fullscreen state with esc key event #5960: The PR fixes the full screen button icon not refreshing by changing how the fullscreen state is handled.
• bug(FullScreenService): sync fullscreen state with esc key event #5960: The PR refactors FullScreenButton component styling and state logic to correctly display icons based on fullscreen state, fixing the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

• Consider if removing the .bb-fs-open class impacts any custom styling or JavaScript relying on it elsewhere.
• Consider separating the parameter deprecation from the bug fix for clearer review history.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a48cdef) to head (f8162d8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5961   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          670       670           
  Lines        30576     30576           
  Branches      4350      4350           
=========================================
  Hits         30576     30576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.