feat(ExportPdfButton): update AutoDownload default value to true#5973
Merged
feat(ExportPdfButton): update AutoDownload default value to true#5973
Conversation
Contributor
Reviewer's GuideThis pull request updates the default value of the Class diagram for ExportPdfButton changesclassDiagram
class ExportPdfButton {
+bool AutoDownload = true
+Func~string, Task~ OnBeforeDownload
+Func~string, Task~ OnAfterDownload
+IHtml2Pdf Html2PdfService
#Task OnClick()
#string? GetMarkupString()
}
note for ExportPdfButton "AutoDownload default value changed from false to true."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Changing the default value of
AutoDownloadmight break existing implementations relying on the previous default; consider explicitly noting this potential breaking change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5973 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 670 670
Lines 30606 30606
Branches 4352 4352
=========================================
Hits 30606 30606 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5972
Summary By Copilot
This pull request updates the
ExportPdfButtoncomponent to enhance its functionality and improve its default behavior. The most notable changes involve modifying theAutoDownloadproperty to default totrueand updating its type and value list in the corresponding attributes.Changes to
ExportPdfButtonbehavior:AutoDownloadproperty inExportPdfButtonto default totrueinstead offalse, ensuring that PDFs are automatically downloaded unless explicitly disabled. (src/BootstrapBlazor/Components/Button/ExportPdfButton.cs, src/BootstrapBlazor/Components/Button/ExportPdfButton.csL62-R65)Updates to attributes:
AutoDownloadattribute inGetAttributes()to reflect its new type (bool), value list (true|false), and default value (true). This ensures consistency with the updated property behavior. (src/BootstrapBlazor.Server/Components/Samples/ExportPdfButtons.razor.cs, src/BootstrapBlazor.Server/Components/Samples/ExportPdfButtons.razor.csL97-R99)Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the ExportPdfButton component to change the default AutoDownload behavior to true
New Features:
Enhancements: