fix(ErrorLogger): add custom OnErrorHandleAsync on Layout not work#6004
Merged
fix(ErrorLogger): add custom OnErrorHandleAsync on Layout not work#6004
Conversation
Contributor
Reviewer's GuideThis pull request updates the File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Invoking
OnErrorHandleAsyncnow prevents the default ErrorBoundary UI from rendering the error; clarify if custom handlers are expected to manage all UI aspects. - Consider passing the
IHandlerExceptioncontext (_cache.LastOrDefault()) toOnErrorHandleAsyncfor consistency with the information available to the default error rendering path.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6004 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 670 670
Lines 30620 30620
Branches 4355 4355
=========================================
Hits 30620 30620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Jayce Liu <129018443+kaishao628@users.noreply.github.com>
This reverts commit 75d4f36.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6003
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance the ErrorLogger component to support a custom OnErrorHandleAsync method for more flexible error handling
Bug Fixes:
Enhancements: