feat(Select): add IsAutoClearSearchTextWhenCollapsed parameter#6024
Merged
feat(Select): add IsAutoClearSearchTextWhenCollapsed parameter#6024
Conversation
Contributor
Reviewer's GuideAdds automatic search text clearing and a collapsed callback to the Select component by introducing two new parameters, wiring a JS hide callback to invoke a Blazor JSInvokable method, updating documentation and tests, and reorganizing the component code. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- There are duplicated implementations of GetSelectedRow (and related helper methods) in the file—consolidate them into a single definition to avoid redundancy.
- The new unit tests call cut.Contains(...) but don’t assert the result; replace those calls with Assert.Contains or Assert.True to actually validate the behavior.
- The reordering of injected services, parameters, and private members makes the diff noisy—consider grouping definitions (e.g. parameters then injections then private members) for clearer structure.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6024 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30873 30888 +15
Branches 4370 4373 +3
=========================================
+ Hits 30873 30888 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6019
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Implement automatic search text clearance and collapse event callback for the Select component by adding new parameters, wiring JS interop hide callback, and updating tests and samples.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: