Skip to content

refactor(FilterProvider): refactoring to improve code readability #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 1 commit into from
May 16, 2025
+13 −16
Merged

refactor(FilterProvider): refactoring to improve code readability #6031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/BootstrapBlazor/Components/Filters/FilterProvider.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@

@if (IsHeaderRow)
{
@RenderFilter()
@RenderFilter
}
else
{
<div class="card filter-item">
<div class="card-header"><span>@Title</span></div>
<div class="card-body">
@RenderFilter()
@RenderFilter
</div>
<div class="card-footer">
<div class="d-flex flex-fill">
Expand All @@ -25,3 +25,10 @@ else
</div>
</div>
}

@code {
RenderFragment RenderFilter =>
@<CascadingValue IsFixed="false" Value="@FilterContext">
@ChildContent
</CascadingValue>;
}
18 changes: 4 additions & 14 deletions src/BootstrapBlazor/Components/Filters/FilterProvider.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,20 +153,10 @@ private void OnClickMinus()
}
}

/// <summary>
/// 渲染自定义过滤器方法
/// </summary>
/// <returns></returns>
protected virtual RenderFragment RenderFilter() => builder =>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Removing virtual RenderFilter breaks override extensibility

This change removes the protected virtual RenderFilter extension point. Please restore a virtual method or add a new override hook.

private FilterContext FilterContext => new()
{
builder.OpenComponent<CascadingValue<FilterContext>>(0);
builder.AddAttribute(1, nameof(CascadingValue<FilterContext>.Value), new FilterContext()
{
Count = Count,
FieldKey = FieldKey,
IsHeaderRow = IsHeaderRow
});
builder.AddAttribute(2, nameof(CascadingValue<FilterContext>.ChildContent), ChildContent);
builder.CloseComponent();
Count = Count,
FieldKey = FieldKey,
IsHeaderRow = IsHeaderRow
};
}