feat(MultipleFilterBase): remove MultipleFilterBase use FilterBase#6033
Merged
feat(MultipleFilterBase): remove MultipleFilterBase use FilterBase#6033
Conversation
Contributor
Reviewer's GuideDeprecates MultipleFilterBase by migrating its Count and Logic parameters into FilterBase and updating all filter components to inherit FilterBase with English XML comments. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| /// <summary> | ||
| /// | ||
| /// DataTime filter component |
Contributor
There was a problem hiding this comment.
suggestion (typo): Typo in summary: 'DataTime' should be 'DateTime'
Suggested change
| /// DataTime filter component | |
| /// DateTime filter component |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6033 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 702 701 -1
Lines 30951 30945 -6
Branches 4376 4375 -1
=========================================
- Hits 30951 30945 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6032
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove MultipleFilterBase in favor of using FilterBase by migrating shared filter properties and behaviors, deprecating the old class, and updating all filter components to inherit from the consolidated base.
Enhancements: