fix(Select): shoulde keep selected item when OnBeforeSelectedItemChange return false

[ArgoZhang]

Link issues

fixes #6035

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Prevent the selected item from being changed when OnBeforeSelectedItemChange returns false

[sourcery-ai]

Reviewer's Guide

Adjusts the Select component’s click handler so that if OnBeforeSelectedItemChange returns false, the method exits immediately and the selected item remains unchanged.

Sequence Diagram: OnClickItem Behavior with OnBeforeSelectedItemChange

sequenceDiagram
    actor User
    participant SelectComponent as Select Component
    participant OnBeforeCb as OnBeforeSelectedItemChange

    User->>SelectComponent: Clicks on an item
    activate SelectComponent
    SelectComponent->>OnBeforeCb: Invoke(item) # Calls the callback
    activate OnBeforeCb
    OnBeforeCb-->>SelectComponent: Returns decision (e.g., false or true)
    deactivate OnBeforeCb

    alt OnBeforeSelectedItemChange returns false
        SelectComponent-->>SelectComponent: Exits OnClickItem() method immediately
        note right of SelectComponent: Selected item remains unchanged (New Behavior)
    else OnBeforeSelectedItemChange returns true
        SelectComponent->>SelectComponent: Proceeds to update selected item (e.g., OnSetSelectedItem(item))
        note right of SelectComponent: Selected item is updated as usual
    end
    deactivate SelectComponent

Loading

Class Diagram: Update to Select Component's OnClickItem Method

classDiagram
    class Select {
        +Task OnClickItem(SelectedItem item)
    }
    note for Select "The OnClickItem method has been updated. If the OnBeforeSelectedItemChange callback returns false, the method now exits immediately. This ensures the selected item remains unchanged, fixing a bug where it might have proceeded with the change erroneously."

Loading

File-Level Changes

Change	Details	Files
Early exit on OnBeforeSelectedItemChange false result	Removed setting of ret = true in the false branch Added return statement to abort further processing when change is canceled	src/BootstrapBlazor/Components/Select/Select.razor.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6035	Allow developers to customize the content and presentation of the confirmation dialog when a dropdown selection changes.	❌	The PR only fixes a bug where the selected item was not kept when OnBeforeSelectedItemChange returned false. It does not implement the requested feature of a new callback OnSelectedItemChanging that allows for custom dialog content.
#6035	Introduce a new callback OnSelectedItemChanging with old and new SelectedItem parameters to allow developers to freely decide the content and presentation of the confirmation dialog.	❌	The PR does not introduce the new callback OnSelectedItemChanging.
#6035	Consider extending similar OnValueChanging callbacks to other form components for consistent handling of value changes and custom dialogs.	❌	The PR does not address extending similar callbacks to other form components.

Possibly linked issues

• feat(Select): 下拉变更前判断优化：自由决定弹框内容。 #6035: The PR modifies the Select component's OnClickItem method to prevent further execution when OnBeforeSelectedItemChange returns false, fixing issue feat(Select): 下拉变更前判断优化：自由决定弹框内容。 #6035.
• feat(Select): 下拉变更前判断优化：自由决定弹框内容。 #6035: The PR fixes the Select control's selection logic, likely resolving the unresponsiveness and double event trigger in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (df12986) to head (f574b9e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6052   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30958     30957    -1     
  Branches      4378      4378           
=========================================
- Hits         30958     30957    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AApuci]

@ArgoZhang 抱歉我又来了，目前的处理代码在以下情况下还是会有问题：
开发自行处理弹框，希望变更值，必须要返回为 true, 此时 内部还代码还会再弹框一次。

另外：目前swal 处理在弹出的表单编辑中可能会有层级显示问题，所以我觉得大佬内部封装这种处理，后面可能会出现其它不可估量的问题。