feat(Table): add IsAutoScrollTopWhenClickPage parameter#6077
Merged
Conversation
Contributor
Reviewer's GuideIntroduces the IsAutoScrollTopWhenClickPage flag to the Table component for optional smooth top-scrolling on pagination clicks via JS interop, fixes a cell alignment key, and updates samples and tests accordingly. Sequence diagram for auto-scrolling on pagination clicksequenceDiagram
actor User
participant TableComponent as "Table Component (C#)"
participant TableJs as "Table.razor.js"
User->>TableComponent: Clicks pagination link
TableComponent->>TableComponent: OnPageLinkClick(pageIndex)
alt IsAutoScrollTopWhenClickPage is true
TableComponent->>TableComponent: _shouldScrollTop = true
end
TableComponent->>TableComponent: OnAfterRenderAsync()
alt _shouldScrollTop is true
TableComponent->>TableComponent: _shouldScrollTop = false
TableComponent->>TableJs: InvokeVoidAsync("scrollTo", Id)
TableJs->>TableJs: scroll.scrollTo({ top: 0, left: 0, behavior: "smooth" })
end
Updated class diagram for Table component and JavaScript interopclassDiagram
class Table~TItem~ {
+IsAutoScrollTopWhenClickPage: bool
-_shouldScrollTop: bool
#OnPageLinkClick(pageIndex: int): Task
#OnAfterRenderAsync(firstRender: bool): Task
}
class TableJsInterop {
<<JavaScript Module: Table.razor.js>>
+scrollTo(id: string): void
}
Table~TItem~ ..> TableJsInterop : invokes
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6077 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30944 30956 +12
Branches 4376 4378 +2
=========================================
+ Hits 30944 30956 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- The alignment icon key change from "align-left" to "align-right" in Table.razor.cs seems unrelated to the scroll feature—consider splitting it into its own PR for clarity.
- In scrollTop, add a guard for when table.tables is empty or undefined to avoid potential runtime errors before accessing tables[0] or tables[1].
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6067
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable optional automatic scrolling to the top of a table upon page navigation by adding the IsAutoScrollTopWhenClickPage parameter, managing the scroll timing post-render, and enhancing the JS scrollTo helper for smooth scrolling.
New Features:
Enhancements:
Documentation:
Tests: