Conversation
Co-Authored-By: Mick Bao <78190214+bgycn@users.noreply.github.com>
Contributor
Reviewer's GuideThis PR simplifies the row‐edit/row‐delete permission logic by dropping the checks for hidden extend buttons and updating tests to match the new behavior. Sequence Diagram for Updated Edit Permission Logic in Table ComponentsequenceDiagram
title Sequence Diagram for Updated Edit Permission Logic in Table Component
actor ClientCode
participant Table
ClientCode->>Table: Call EditAsync() for a selected row
Table->>Table: Check ProhibitEdit() for the row
alt ShowExtendEditButtonCallback is defined AND ShowExtendEditButtonCallback(row) returns false
Table-->>ClientCode: Edit prohibited (due to ShowExtendEditButtonCallback)
else DisableExtendEditButtonCallback is defined AND DisableExtendEditButtonCallback(row) returns true
Table-->>ClientCode: Edit prohibited (due to DisableExtendEditButtonCallback)
else DisableExtendEditButton is true
Table-->>ClientCode: Edit prohibited (due to DisableExtendEditButton)
else
Table->>Table: Proceed with edit operation
Table-->>ClientCode: Edit successful / UI updated
end
Sequence Diagram for Updated Delete Permission Logic in Table ComponentsequenceDiagram
title Sequence Diagram for Updated Delete Permission Logic in Table Component
actor ClientCode
participant Table
ClientCode->>Table: Call Delete for selected rows
Table->>Table: Check ProhibitDelete() for selected rows
alt ShowExtendDeleteButtonCallback is defined AND ShowExtendDeleteButtonCallback(any row) returns false
Table-->>ClientCode: Delete prohibited (due to ShowExtendDeleteButtonCallback)
else DisableExtendDeleteButtonCallback is defined AND DisableExtendDeleteButtonCallback(any row) returns true
Table-->>ClientCode: Delete prohibited (due to DisableExtendDeleteButtonCallback)
else DisableExtendDeleteButton is true
Table-->>ClientCode: Delete prohibited (due to DisableExtendDeleteButton)
else
Table->>Table: Proceed with delete operation
Table-->>ClientCode: Delete successful / UI updated
end
Updated Class Diagram for Table ComponentclassDiagram
title Updated Class Diagram for Table Component
class Table {
+List<TItem> SelectedRows
+bool ShowExtendEditButton
+bool DisableExtendEditButton
+Func<TItem, bool> ShowExtendEditButtonCallback
+Func<TItem, bool> DisableExtendEditButtonCallback
+bool ShowExtendDeleteButton
+bool DisableExtendDeleteButton
+Func<TItem, bool> ShowExtendDeleteButtonCallback
+Func<TItem, bool> DisableExtendDeleteButtonCallback
+EditAsync() void
+ConfirmDelete() Task<bool>
-ProhibitEdit() bool
-ProhibitDelete() bool
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30970 30968 -2
Branches 4380 4380
=========================================
- Hits 30970 30968 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6089
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove ShowExtendEditButton and ShowExtendDeleteButton flags from the internal edit/delete prohibition logic so that disabling those UI buttons no longer blocks programmatic calls, and update corresponding unit tests to reflect the new behavior.
Bug Fixes:
Tests: