feat(TabItem): add ErrorLogger support on TabItem#6143
Merged
Conversation
Contributor
Reviewer's GuideThis PR integrates the ErrorLogger component into TabItem by extending the Tab component with configurable logger parameters, refactoring TabItemContent to wrap its content in ErrorLogger using those settings, and updating the Layout component to source defaults from configuration and forward them to both ErrorLogger and Tab. Updated Class Diagram: ErrorLogger Integration ComponentsclassDiagram
class Layout {
+IOptionsMonitor_BootstrapBlazorOptions_ Options (new)
-_enableErrorLogger: bool (new)
-_showToast: bool (new)
}
class Tab {
+bool? EnableErrorLogger (new)
+bool? ShowErrorLoggerToast (new)
+string? ErrorLoggerToastTitle (new)
}
class TabItemContent {
-Layout? Layout (removed CascadingParameter)
+Tab TabSet (new CascadingParameter)
+RenderItemContent() (updated to use TabSet)
}
class BootstrapBlazorOptions {
+bool EnableErrorLogger
+bool ShowErrorLoggerToast
}
class ErrorLogger {
+RenderFragment ChildContent
+bool? EnableErrorLogger
+bool? ShowToast
+string? ToastTitle
}
Layout ..> BootstrapBlazorOptions : Reads defaults for own ErrorLogger
Layout ..> Tab : Passes settings to
TabItemContent ..> Tab : Accesses TabSet for ErrorLogger settings
TabItemContent ..> ErrorLogger : Instantiates & Configures
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31084 31088 +4
Branches 4397 4395 -2
=========================================
+ Hits 31084 31088 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6142
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable configurable error logging on Tab and TabItem components by exposing new parameters and embedding the ErrorLogger component around tab content, while refactoring cascading parameters and sourcing defaults from global options.
New Features:
Enhancements: