Skip to content

test(Upload): improve code coverage #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 9 commits into from
Jun 6, 2025
Merged

test(Upload): improve code coverage #6168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dece8a7
refactor: 获得文件扩展名方法
ArgoZhang Jun 6, 2025
83be2fa
test: 测试单元测试
ArgoZhang Jun 6, 2025
c1dde8c
Revert "test: 测试单元测试"
ArgoZhang Jun 6, 2025
667b171
chore: 更新 codecov action 版本
ArgoZhang Jun 6, 2025
a0c74c7
refactor: 更改可为空检查
ArgoZhang Jun 6, 2025
9d16a5d
test: 增加 Flags 参数
ArgoZhang Jun 6, 2025
88dd246
chore: 更新 action 版本
ArgoZhang Jun 6, 2025
cc9efd4
revert: 恢复代码
ArgoZhang Jun 6, 2025
7209371
test: 更新单元测试
ArgoZhang Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/auto-pull-request-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
dotnet test test/UnitTest --collect:"XPlat Code Coverage"

- name: Upload to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: BB
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
dotnet test test/UnitTest --collect:"XPlat Code Coverage"

- name: Upload to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}

Expand Down
8 changes: 4 additions & 4 deletions src/BootstrapBlazor/Components/Upload/UploadPreviewList.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,17 +252,17 @@ private async Task OnClickCancel(UploadFile item)
private string? GetFileFormatClassString(UploadFile item)
{
var builder = CssBuilder.Default("file-icon");
var fileExtension = Path.GetExtension(item.OriginFileName ?? item.FileName);
var fileExtension = Path.GetExtension(item.GetFileName());
if (!string.IsNullOrEmpty(fileExtension))
{
fileExtension = fileExtension.ToLowerInvariant();
var icon = OnGetFileFormat?.Invoke(fileExtension) ?? GetFileExtensions(fileExtension);
builder.AddClass(icon);
}
var icon = OnGetFileFormat?.Invoke(fileExtension) ?? GetFileExtensions(fileExtension);
builder.AddClass(icon);
return builder.Build();
}

private string? GetFileExtensions(string? fileExtension) => fileExtension switch
private string? GetFileExtensions(string fileExtension) => fileExtension switch
{
".csv" or ".xls" or ".xlsx" => FileIconExcel,
".doc" or ".docx" or ".dot" or ".dotx" => FileIconDocx,
Expand Down
2 changes: 1 addition & 1 deletion test/UnitTest/Components/UploadButtonTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ public void ButtonUpload_OnGetFileFormat_Ok()
new() { FileName = "1.doc" },
new() { FileName = "1.docx" },
new() { FileName = "1.dot" },
new() { FileName = "1.dotx" },
new() { FileName = "1.ppt" },
new() { FileName = "1.pptx" },
new() { FileName = "1.wav" },
Expand Down Expand Up @@ -397,7 +398,6 @@ public void ButtonUpload_OnGetFileFormat_Ok()
cut.Contains("fa-file-archive");
cut.Contains("fa-file-text");
cut.Contains("fa-file-image");
cut.Contains("fa-file-archive");
cut.Contains("fa-file");

cut.SetParametersAndRender(pb =>
Expand Down