fix(Login): update Template5 login template return button style#6186
Merged
fix(Login): update Template5 login template return button style#6186
Conversation
|
Thanks for your PR, @MadLongTom. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's GuideRefines Template5 CSS by adjusting header alignment, z-index stacking, typography sizing and margins, and reorganizing the logo container flex layout. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31099 31099
Branches 4394 4394
=========================================
Hits 31099 31099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey @MadLongTom - I've reviewed your changes - here's some feedback:
- Instead of removing
justify-content: centerentirely, consider usingjustify-content: space-betweenon.header-rowso the return button, title, and logo stay evenly distributed without arbitrary margins. - The hard-coded
margin-left/right: 40pxon.logo-containercould break mobile layouts—consider using flex gaps or percentage-based padding for responsive spacing. - Adding
z-index: 2to the return button container may introduce stacking issues; ensure its stacking context is clearly scoped or documented to avoid overlap with future elements.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ArgoZhang
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6187
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix CSS styles in Template5 sample to correct the return button stacking and align header text and logo properly.
Bug Fixes:
justify-content: centerfrom.header-rowand addz-index: 2to restore proper return button positioningEnhancements:
.blazor-textfont size to 1.8rem and reset its margin for consistent spacing.logo-containerto use flex centering with side margins instead of auto margins