Conversation
Contributor
Reviewer's GuideThis PR upgrades Bootstrap dependency from v5.3.3 to v5.3.6 by replacing the core CSS/JS assets (including RTL and ES-module builds), updating version headers and source maps, and applies housekeeping tweaks in CSS rules and JS utilities for Popper integration and accessibility. Sequence Diagram: Dropdown Hide Focus Behavior Change in Bootstrap v5.3.6sequenceDiagram
actor User
participant DropdownToggle as "Dropdown Toggle"
participant DropdownMenu as "Dropdown Menu Component"
participant Browser as "Browser"
User->>+DropdownToggle: Interacts to hide dropdown (e.g., click, Esc)
DropdownToggle->>DropdownMenu: Signal to hide
DropdownMenu-->>DropdownToggle: Processes hide (animations, state changes)
DropdownToggle->>DropdownToggle: Updates ARIA attributes (e.g., aria-expanded="false")
critical "New Focus Behavior on Hide"
DropdownToggle->>Browser: request focus() on Dropdown Toggle
Browser-->>DropdownToggle: Focus set to Dropdown Toggle
end
DropdownToggle-->>-User: Dropdown hidden, focus returned to toggle
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31099 31099
Branches 4394 4394
=========================================
Hits 31099 31099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- It looks like you manually replaced the raw Bootstrap CSS/JS files—consider switching to an npm or NuGet package reference for Bootstrap so future upgrades can be automated instead of committing huge diffs of third-party code.
- Double-check that your application (package.json, index.html, import paths, etc.) is updated to reference the new ES module build (bootstrap.esm.min.js) and the bumped version (5.3.6) everywhere it’s used.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| }); | ||
| }; | ||
| const execute = (possibleCallback, args = [], defaultValue = possibleCallback) => { | ||
| return typeof possibleCallback === 'function' ? possibleCallback(...args) : defaultValue; |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Incorrect use of Function.call in execute helper
Using call(...args) changes the this context and argument handling. Consider reverting to the previous approach or use apply if a specific context is needed.
| if (!this._isEnabled) { | ||
| return; | ||
| } | ||
| this._activeTrigger.click = !this._activeTrigger.click; |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Removed click-trigger toggle in dropdown
Please verify that the dropdown still toggles correctly on repeated clicks after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6190
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update BootstrapBlazor to use Bootstrap v5.3.6 by replacing core CSS and JS assets and adjust related code for the new version
Bug Fixes:
Enhancements: