Skip to content

feat(Select): redesign OnBeforeSelectedItemChange logic#6199

Merged
ArgoZhang merged 3 commits intomainfrom
fix-select
Jun 10, 2025
Merged

feat(Select): redesign OnBeforeSelectedItemChange logic#6199
ArgoZhang merged 3 commits intomainfrom
fix-select

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Jun 10, 2025

Link issues

fixes #6198

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Redesign the selection change workflow by separating the pre-change callback and optional Swal confirmation steps, update the default behavior of ShowSwal, and refresh parameter documentation.

Enhancements:

  • Redesign OnBeforeSelectedItemChange handling to separate pre-change callback and Swal confirmation steps
  • Change default value of ShowSwal to false
  • Update XML docs for OnBeforeSelectedItemChange and ShowSwal parameters
  • Add Chinese comments alongside existing English documentation

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jun 10, 2025

Reviewer's Guide

This PR redesigns the Select component’s pre-selection workflow by decoupling the OnBeforeSelectedItemChange callback from the Swal confirmation step, updating default behaviors, and streamlining the OnClickItem handler implementation.

File-Level Changes

Change Details Files
Updated parameter defaults and documentation for pre-change callback and confirmation flag
  • Revised XML docs for OnBeforeSelectedItemChange to include bilingual comments
  • Changed ShowSwal default from true to false and removed its initializer
  • Updated ShowSwal XML comments to reflect new default value
src/BootstrapBlazor/Components/Select/Select.razor.cs
Refactored OnClickItem flow to separate callback and modal logic
  • Isolated OnBeforeSelectedItemChange invocation with early exit on false
  • Moved Swal modal creation and display inside a conditional block checking ret and ShowSwal
  • Adjusted SwalFooter handling and awaited ShowModal result to set ret
  • Streamlined final ret check to update selected item
src/BootstrapBlazor/Components/Select/Select.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6198 Redesign the OnBeforeSelectedItemChange logic in the Select component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Jun 10, 2025
@bb-auto bb-auto Bot added this to the 9.7.0 milestone Jun 10, 2025
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • The default for ShowSwal was flipped from true to false, which is a breaking change—please call this out in your release notes or consider a major version bump.
  • The mixed Chinese/English XML documentation on OnBeforeSelectedItemChange could be consolidated to match the project's language conventions.
  • You might simplify OnClickItem by using early returns when ret is false or by extracting the Swal modal setup into a helper to reduce nesting.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ba4e74) to head (4d6fd47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31100     31100           
  Branches      4394      4394           
=========================================
  Hits         31100     31100           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 75553b8 into main Jun 10, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-select branch June 10, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Select): redesign OnBeforeSelectedItemChange logic

1 participant