Skip to content

fix(Table): support value type#7307

Merged
ArgoZhang merged 2 commits intomainfrom
fix-table
Dec 12, 2025
Merged

fix(Table): support value type#7307
ArgoZhang merged 2 commits intomainfrom
fix-table

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 12, 2025

Link issues

fixes #7304 #7293

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Return default values instead of null when accessing value-type properties on null instances in generated table expressions to prevent runtime errors.

Copilot AI review requested due to automatic review settings December 12, 2025 03:32
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the expression-building logic for property access to correctly handle value-type properties when the instance is null, aligning null-handling semantics for reference and value types.

Class diagram for updated BuildPropertyAccess in LambdaExtensions

classDiagram
    class LambdaExtensions {
        +ConditionalExpression BuildPropertyAccess(Expression instance, Type instanceType, string propertyName)
    }

    class Expression
    class ConditionalExpression
    class Type

    LambdaExtensions ..> Expression : uses
    LambdaExtensions ..> ConditionalExpression : returns
    LambdaExtensions ..> Type : uses
Loading

File-Level Changes

Change Details Files
Update lambda expression property-access helper to return appropriate defaults for value-type properties when the target instance is null.
  • Detect whether the accessed property type is a value type before constructing the conditional expression.
  • For value-type properties, use Expression.Default(propertyType) as the conditional true branch when the instance is null.
  • For reference-type properties, preserve existing behavior of returning a null constant when the instance is null.
  • Keep property access and null-check logic otherwise unchanged.
src/BootstrapBlazor/Extensions/LambdaExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7304 Fix Table navigation column rendering so that navigation properties with non-nullable value types (e.g., decimal, int, double) do not throw errors and render normally.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the bug Something isn't working label Dec 12, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 12, 2025
@ArgoZhang ArgoZhang merged commit f9aa99e into main Dec 12, 2025
6 of 8 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch December 12, 2025 03:33
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The conditional expression creation now has duplicated Expression.Condition logic; consider extracting the test expression and using a single condition with only the ifTrue expression differing to improve readability.
  • Double-check whether you need to special-case Nullable<T> separately from other value types, since Expression.Default on a nullable value type yields null, which may or may not be what existing consumers expect when the instance is null.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The conditional expression creation now has duplicated `Expression.Condition` logic; consider extracting the `test` expression and using a single condition with only the `ifTrue` expression differing to improve readability.
- Double-check whether you need to special-case `Nullable<T>` separately from other value types, since `Expression.Default` on a nullable value type yields `null`, which may or may not be what existing consumers expect when the instance is null.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.99%. Comparing base (81ca44c) to head (f087c0c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/BootstrapBlazor/Extensions/LambdaExtensions.cs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #7307      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          745      745              
  Lines        32631    32637       +6     
  Branches      4522     4523       +1     
===========================================
+ Hits         32631    32636       +5     
- Partials         0        1       +1     
Flag Coverage Δ
BB 99.99% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the Table component where accessing nested properties with value types would fail. The issue occurred when building expression trees for complex property paths that included value types (like integers, enums, or structs).

Key Changes:

  • Modified BuildPropertyAccess method to differentiate between value types and reference types when creating null-check expressions
  • Updated version from 10.1.4-beta03 to 10.1.4-beta04

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Extensions/LambdaExtensions.cs Fixed expression tree generation to use Expression.Default for value types instead of Expression.Constant(null), preventing runtime errors when accessing nested value type properties
src/BootstrapBlazor/BootstrapBlazor.csproj Incremented version number to reflect the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): 导航属性报错

2 participants