Skip to content

fix(PopConfirmButton): parameter IsKeepDisabled not work #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 3 commits into from
Dec 13, 2025
Merged

fix(PopConfirmButton): parameter IsKeepDisabled not work #7319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68a7682
fix(PopConfirmButton): parameter IsKeepDisabled not work
ArgoZhang Dec 13, 2025
42b8802
doc: 更新文档
ArgoZhang Dec 13, 2025
763d193
chore: bump version 10.1.4-beta05
ArgoZhang Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor.Server/Locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@
"PopoverConfirmsContentDelete": "Delete confirmation button",
"PopoverConfirmsContentDeleteContent": "Are you sure you want to delete the data?",
"PopoverConfirmsIsAsyncTitle": "Asynchronous confirmation",
"PopoverConfirmsIsAsyncIntro": "By setting the <code>IsAsync</code> attribute, the data is submitted asynchronously when the confirm button is clicked",
"PopoverConfirmsIsAsyncIntro": "By setting the <code>IsAsync</code> attribute, the data is submitted asynchronously when the confirm button is clicked. In some specific scenarios, the button needs to remain disabled after asynchronous operation. Please control this using the <code>IsKeepDisabled</code> parameter.",
"PopoverConfirmsIsAsyncConfirmationText": "Asynchronous confirmation",
"PopoverConfirmsIsAsyncConfirmationContent": "Are you sure you want to delete the data?",
"PopoverConfirmsFormTitle": "form submission",
Expand Down
2 changes: 1 addition & 1 deletion src/BootstrapBlazor.Server/Locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@
"PopoverConfirmsContentDelete": "删除确认按钮",
"PopoverConfirmsContentDeleteContent": "确定删除数据吗？",
"PopoverConfirmsIsAsyncTitle": "异步确认",
"PopoverConfirmsIsAsyncIntro": "通过设置 <code>IsAsync</code> 属性点击确认按钮时异步进行数据提交",
"PopoverConfirmsIsAsyncIntro": "通过设置 <code>IsAsync</code> 属性点击确认按钮时异步进行数据提交。有些特定场景异步后需要按钮继续保持禁用状态，请通过 <code>IsKeepDisabled</code> 参数控制",
"PopoverConfirmsIsAsyncConfirmationText": "异步确认",
"PopoverConfirmsIsAsyncConfirmationContent": "确定删除数据吗？",
"PopoverConfirmsFormTitle": "表单提交",
Expand Down
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.1.4-beta04</Version>
<Version>10.1.4-beta05</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/BootstrapBlazor/Components/Button/PopConfirmButton.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the Apache 2.0 License
// See the LICENSE file in the project root for more information.
// Maintainer: Argo Zhang(argo@live.ca) Website: https://www.blazor.zone
Expand Down Expand Up @@ -111,7 +111,7 @@ private async Task OnClickConfirm()
}
else
{
IsDisabled = false;
IsDisabled = IsKeepDisabled;
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IsKeepDisabled functionality lacks test coverage in PopConfirmButton. While Button has test coverage for this feature (ButtonTest.cs lines 223-231), PopConfirmButton does not. Consider adding a test case to verify that when IsAsync and IsKeepDisabled are both true, the button remains disabled after the async operation completes.

Copilot uses AI. Check for mistakes.
IsAsyncLoading = false;
StateHasChanged();
}
Expand Down
Loading