fix(PdfReader): render pdf when set ShowToolbar is false#7329
Merged
fix(PdfReader): render pdf when set ShowToolbar is false#7329
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the sample PDF reader component so that it references the correct relative PDF path, ensuring the PDF still renders even when ShowToolbar is set to false. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7329 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 747 747
Lines 32760 32760
Branches 4540 4540
=========================================
Hits 32760 32760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where PDF files fail to render when the ShowToolbar property is set to false. The fix involves updating the BootstrapBlazor.PdfReader package to version 10.0.16 and correcting the default PDF URL path in the sample component.
- Updated BootstrapBlazor.PdfReader package from version 10.0.15 to 10.0.16
- Corrected the default PDF URL path to use the proper relative path format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor.cs | Updated the default PDF URL from "sample.pdf" to "./samples/sample.pdf" to use the correct relative path format, consistent with other PDF components |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Upgraded BootstrapBlazor.PdfReader package version from 10.0.15 to 10.0.16, which likely contains the ShowToolbar rendering fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7328
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: