Skip to content

feat(Chart): support custome BackgroundColor#7352

Merged
ArgoZhang merged 4 commits intomainfrom
feat-chart
Dec 17, 2025
Merged

feat(Chart): support custome BackgroundColor#7352
ArgoZhang merged 4 commits intomainfrom
feat-chart

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 17, 2025

Link issues

fixes #7348

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Reformat bar chart dataset initialization for improved readability in the server sample.

Copilot AI review requested due to automatic review settings December 17, 2025 04:34
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 17, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the Bar chart sample dataset initialization for clarity and consistency without changing behavior, and removes the BOM marker from the file header comment.

File-Level Changes

Change Details Files
Refactor bar chart sample dataset construction for readability without altering behavior.
  • Expand inline ChartDataset object initialization into multi-line object initializer with explicit properties
  • Preserve existing label generation and random data generation logic for chart data source
  • Keep method signature and return behavior of OnInit unchanged
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7348 Enable ChartDataset.BackgroundColor to control the legend rectangle fill color and the line color for line charts. The PR only reformats the Bar chart sample code and does not change any chart rendering logic or how BackgroundColor is used for line charts.
#7348 Enable ChartDataset.BorderColor to optionally draw a border around the legend rectangle and the drawn line for line charts (null by default). There are no changes in the PR touching BorderColor or line chart rendering; BorderColor behavior remains unchanged.
#7348 Generalize color customization support (BackgroundColor and BorderColor) so it works for all relevant chart types, not just bar charts. The PR modifies only a Bar chart sample dataset construction and does not introduce any new color customization support across chart types.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Dec 17, 2025
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The PR title and linked issue suggest adding support for custom chart background color, but the diff only shows minor formatting changes; either the implementation is missing or the title/issue reference should be updated for clarity.
  • The license header change removed the BOM/leading character on the first line; double-check this was intentional and aligns with the repository’s encoding conventions for source files.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title and linked issue suggest adding support for custom chart background color, but the diff only shows minor formatting changes; either the implementation is missing or the title/issue reference should be updated for clarity.
- The license header change removed the BOM/leading character on the first line; double-check this was intentional and aligns with the repository’s encoding conventions for source files.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

# Conflicts:
#	src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj
@ArgoZhang ArgoZhang dismissed sourcery-ai[bot]’s stale review December 17, 2025 04:34

The merge-base changed after approval.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (264b9d6) to head (a0325ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          747       747           
  Lines        32760     32760           
  Branches      4540      4540           
=========================================
  Hits         32760     32760           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang merged commit 0d0bf5c into main Dec 17, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the feat-chart branch December 17, 2025 04:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for custom BackgroundColor in the Chart component by upgrading the BootstrapBlazor.Chart package to version 10.0.1-beta02.

Note: The PR title contains a spelling error: "custome" should be "custom".

Key Changes

  • Updated BootstrapBlazor.Chart package from version 10.0.0 to 10.0.1-beta02
  • Minor code formatting improvements in Bar.razor.cs for better readability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Updated BootstrapBlazor.Chart package version to 10.0.1-beta02 to enable custom BackgroundColor support
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor.cs Reformatted ChartDataset initialization for improved code readability (multi-line format)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Chart): Allow customizing colors of legends and data lines on Line Charts

2 participants