Skip to content

fix(Editor): update editor script for upload image work#7383

Merged
ArgoZhang merged 2 commits intomainfrom
fix-editor
Dec 21, 2025
Merged

fix(Editor): update editor script for upload image work#7383
ArgoZhang merged 2 commits intomainfrom
fix-editor

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 21, 2025

Link issues

fixes #7382

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Clean up the Editors.razor page declaration to avoid BOM-related artifacts in the editor route line.

Copilot AI review requested due to automatic review settings December 21, 2025 11:18
@bb-auto bb-auto Bot added the bug Something isn't working label Dec 21, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 21, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Normalize the Editors.razor page directive to remove a leading BOM/hidden character so the editor sample route is correctly recognized; csproj appears untouched aside from potential whitespace or metadata changes.

File-Level Changes

Change Details Files
Normalize the editor sample Razor page directive so the /editor route is clean and free of hidden characters.
  • Removed the leading BOM/hidden character before the @page directive so the route is exactly "/editor".
  • Ensured the Razor component starts cleanly at the @page directive without extraneous characters that could affect routing or tooling.
src/BootstrapBlazor.Server/Components/Samples/Editors.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7382 Fix the Editor image upload functionality so that uploading an image in the rich text editor produces a response/works correctly instead of having no reaction. The PR diff only removes a BOM character from Editors.razor (@page line) and shows no functional changes to the editor logic, upload handling, or related scripts. There are no code changes that could affect the image upload behavior, so the described bug is not actually addressed.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit c73108a into main Dec 21, 2025
7 of 8 checks passed
@ArgoZhang ArgoZhang deleted the fix-editor branch December 21, 2025 11:18
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes image upload functionality in the Editor component by updating the BootstrapBlazor.SummerNote package from version 10.0.0 to 10.0.1, which contains the necessary fix for issue #7382.

  • Package version bump for BootstrapBlazor.SummerNote (10.0.0 → 10.0.1)
  • BOM character removal from Editors.razor file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor.Server/Components/Samples/Editors.razor Removes BOM character from the start of the file
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Updates BootstrapBlazor.SummerNote package to version 10.0.1 to fix image upload functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/BootstrapBlazor.Server/Components/Samples/Editors.razor
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (227ead3) to head (5f6927e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Editor): 上传图片富文本框无反应

2 participants