Skip to content

feat(UniverSheet): add RibbonType parameter#7387

Merged
ArgoZhang merged 1 commit intomainfrom
feat-univer
Dec 22, 2025
Merged

feat(UniverSheet): add RibbonType parameter#7387
ArgoZhang merged 1 commit intomainfrom
feat-univer

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 22, 2025

Link issues

fixes #7386

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Document and demonstrate the UniverSheet RibbonType option in the sample page.

New Features:

  • Set the UniverSheet component in the sample to use the Default RibbonType configuration.

Documentation:

  • Add localized description text explaining the UniverSheet RibbonType behavior in both English and Chinese locales.

Copilot AI review requested due to automatic review settings December 22, 2025 04:17
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 22, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 22, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for configuring the UniverSheet RibbonType in the UniverSheets sample and updates localized documentation text accordingly.

Updated class diagram for UniverSheet usage with RibbonType

classDiagram
  class UniverSheetsSample {
    - UniverSheet _sheetExcel
    + OnPushExcelData()
    + OnSaveExcelData()
    + OnReadyAsync()
  }

  class UniverSheet {
    + UniverSheetRibbonType RibbonType
    + OnReadyAsync()
  }

  class UniverSheetRibbonType {
  }
  <<enumeration>> UniverSheetRibbonType

  UniverSheetsSample --> UniverSheet : uses
  UniverSheet --> UniverSheetRibbonType : has
Loading

File-Level Changes

Change Details Files
Wire UniverSheet sample to use the new RibbonType parameter and document it in the demo UI.
  • Add an extra localized paragraph in the UniverSheets sample describing the RibbonType behavior/usage.
  • Pass the new RibbonType parameter to the UniverSheet component, defaulting to UniverSheetRibbonType.Default.
  • Normalize the Razor file encoding/BOM on the @page directive line.
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor
Extend localization resources to describe the new RibbonType option in the UniverSheet sample.
  • Add an English localized string (NormalDescRibbonType) used by the UniverSheets sample to explain the RibbonType feature.
  • Add a Chinese localized string (NormalDescRibbonType) with equivalent content for the UniverSheets sample.
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#7386 Add a RibbonType parameter to the UniverSheet usage so that the ribbon type can be configured.
#7386 Update the UniverSheet sample/documentation text to describe or reflect the new RibbonType parameter.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 1ed02a1 into main Dec 22, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the feat-univer branch December 22, 2025 04:18
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the RibbonType parameter to the UniverSheet component, allowing users to configure the toolbar style. The changes include documentation updates in both English and Chinese localization files, and a demonstration of the new parameter in the sample component.

  • Added localization entries to document the new RibbonType parameter
  • Updated the UniverSheet demo to showcase the RibbonType parameter usage with a default value

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor.Server/Locales/zh-CN.json Added Chinese localization for RibbonType parameter description
src/BootstrapBlazor.Server/Locales/en-US.json Added English localization for RibbonType parameter description
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor Added RibbonType parameter to the demo component and included descriptive text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (29c928f) to head (2853996).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(UniverSheet): add RibbonType parameter

2 participants