Skip to content

fix(Carousel): use visually-hidden class#7393

Merged
ArgoZhang merged 2 commits intomainfrom
fix-carousel
Dec 23, 2025
Merged

fix(Carousel): use visually-hidden class#7393
ArgoZhang merged 2 commits intomainfrom
fix-carousel

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 23, 2025

Link issues

fixes #7392

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Replace deprecated sr-only class with visually-hidden on Carousel previous/next labels to align with current Bootstrap accessibility practices.

Copilot AI review requested due to automatic review settings December 23, 2025 00:53
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 23, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 23, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Carousel component’s navigation controls to use the modern Bootstrap visually-hidden utility class instead of the deprecated sr-only class for the Previous/Next labels.

File-Level Changes

Change Details Files
Replace deprecated screen-reader-only class with the current Bootstrap visually hidden utility for carousel controls.
  • Updated the Previous control label span to use the visually-hidden class instead of sr-only.
  • Updated the Next control label span to use the visually-hidden class instead of sr-only.
  • Removed an extraneous BOM character at the top of the Razor file, normalizing the @namespace line.
src/BootstrapBlazor/Components/Carousel/Carousel.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7392 Add a configurable option (e.g., a property or parameter on the Carousel component) to control whether the control button text labels (e.g., 'Previous' and 'Next') are shown, so users don’t need to hide them via custom CSS. The PR only changes the CSS class on the button text spans from sr-only to visually-hidden. It does not introduce any new parameter, switch, or conditional rendering to toggle the visibility of the control button text, so users still cannot control this behavior via the component API.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The hardcoded "Previous" and "Next" labels could be wired into your existing localization/resources instead of inline strings to keep the carousel controls localizable.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The hardcoded "Previous" and "Next" labels could be wired into your existing localization/resources instead of inline strings to keep the carousel controls localizable.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 41c96ae into main Dec 23, 2025
8 checks passed
@ArgoZhang ArgoZhang deleted the fix-carousel branch December 23, 2025 00:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Carousel component to use Bootstrap 5's visually-hidden class instead of the deprecated Bootstrap 4 sr-only class for accessibility labels, fixing issue #7392.

  • Replaced sr-only with visually-hidden in carousel control buttons
  • Updated package version to 10.1.5-beta01

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Components/Carousel/Carousel.razor Updated accessibility class from sr-only to visually-hidden for Previous and Next control labels
src/BootstrapBlazor/BootstrapBlazor.csproj Bumped version from 10.1.4 to 10.1.5-beta01 for the new beta release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (799d0b2) to head (f127bc8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7393   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Carousel 走马灯组件中,是否可以考虑将那个控制按钮文字显示加个开关

2 participants