Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Carousel component’s navigation controls to use the modern Bootstrap File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The hardcoded "Previous" and "Next" labels could be wired into your existing localization/resources instead of inline strings to keep the carousel controls localizable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hardcoded "Previous" and "Next" labels could be wired into your existing localization/resources instead of inline strings to keep the carousel controls localizable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR updates the Carousel component to use Bootstrap 5's visually-hidden class instead of the deprecated Bootstrap 4 sr-only class for accessibility labels, fixing issue #7392.
- Replaced
sr-onlywithvisually-hiddenin carousel control buttons - Updated package version to 10.1.5-beta01
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Carousel/Carousel.razor | Updated accessibility class from sr-only to visually-hidden for Previous and Next control labels |
| src/BootstrapBlazor/BootstrapBlazor.csproj | Bumped version from 10.1.4 to 10.1.5-beta01 for the new beta release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7393 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32793 32793
Branches 4551 4551
=========================================
Hits 32793 32793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7392
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: