Skip to content

refactor(IFilterAction): remove JsonDerivedType attribute#7399

Merged
ArgoZhang merged 1 commit intomainfrom
dev-json
Dec 23, 2025
Merged

refactor(IFilterAction): remove JsonDerivedType attribute#7399
ArgoZhang merged 1 commit intomainfrom
dev-json

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 23, 2025

Link issues

fixes #7398

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Remove the JsonDerivedType attribute and associated using from IFilterAction to avoid tying the interface to a specific serialization mechanism.

Copilot AI review requested due to automatic review settings December 23, 2025 01:23
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 23, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 23, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the System.Text.Json polymorphic serialization attribute from the IFilterAction interface, decoupling it from a specific derived implementation and its JSON configuration.

File-Level Changes

Change Details Files
Decouple IFilterAction from System.Text.Json-specific polymorphic configuration.
  • Removed the using directive for System.Text.Json.Serialization since it is no longer needed.
  • Removed the JsonDerivedType attribute that bound IFilterAction to the SerializeFilterAction derived type.
src/BootstrapBlazor/Components/Filters/IFilterAction.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7398 Remove the JsonDerivedType attribute (and associated dependency) from the IFilterAction interface.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 30c29bb into main Dec 23, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the dev-json branch December 23, 2025 01:23
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (41c96ae) to head (2e78868).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused JsonDerivedType attribute from the IFilterAction interface. The attribute is unnecessary because JSON serialization of IFilterAction instances is handled by a custom JsonQueryPageOptionsConverter that explicitly manages type conversions.

  • Removes JsonDerivedType attribute and its associated using statement
  • Simplifies the interface definition while maintaining all functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(IFilterAction): remove JsonDerivedType attribute

2 participants