Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the System.Text.Json polymorphic serialization attribute from the IFilterAction interface, decoupling it from a specific derived implementation and its JSON configuration. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32793 32793
Branches 4551 4551
=========================================
Hits 32793 32793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the unused JsonDerivedType attribute from the IFilterAction interface. The attribute is unnecessary because JSON serialization of IFilterAction instances is handled by a custom JsonQueryPageOptionsConverter that explicitly manages type conversions.
- Removes
JsonDerivedTypeattribute and its associated using statement - Simplifies the interface definition while maintaining all functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Link issues
fixes #7398
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: