Skip to content

feat(Button): add active style#7415

Merged
ArgoZhang merged 2 commits intomainfrom
feat-style
Dec 25, 2025
Merged

feat(Button): add active style#7415
ArgoZhang merged 2 commits intomainfrom
feat-style

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 25, 2025

Link issues

fixes #7402

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the Motronic theme stylesheet to support an active visual style for buttons.

Copilot AI review requested due to automatic review settings December 25, 2025 07:54
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 25, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 25, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 25, 2025
@ArgoZhang ArgoZhang merged commit 280d79a into main Dec 25, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the feat-style branch December 25, 2025 07:55
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (de58e46) to head (2263e6a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds distinct active background colors to button components to provide better visual feedback when buttons are pressed, addressing issue #7402 where users reported difficulty perceiving button press actions during fast operations (particularly for table refresh/search buttons).

Key Changes:

  • Replaced generic var(--bs-btn-hover-bg) values with specific hex colors for --bs-btn-active-bg across all button color variants
  • Added --bs-btn-active-color properties for specific outline button variants
  • Modified border color properties for .btn-outline-link

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +272 to +273
--bs-btn-active-bg: #612ad6;
--bs-btn-active-color: var(--bs-btn-hover-color);
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --bs-btn-active-color property is added for .btn-outline-info but is inconsistently applied across outline button variants. This property should either be added to all outline buttons that need it (secondary, success, warning, danger, dark) or removed if not necessary. Currently, only .btn-outline-info and .btn-outline-light have this property defined, which creates inconsistency in the button styling pattern.

Copilot uses AI. Check for mistakes.
Comment on lines +318 to +319
--bs-btn-active-border-color: var(--bs-btn-border-color);
--bs-btn-hover-border-color: var(--bs-btn-border-color);
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property order appears incorrect for .btn-outline-link. The --bs-btn-hover-border-color property is being redefined after --bs-btn-active-border-color, which breaks the typical CSS custom property declaration order (hover properties should come before active properties). Consider moving line 319 to before line 318 to maintain proper ordering.

Suggested change
--bs-btn-active-border-color: var(--bs-btn-border-color);
--bs-btn-hover-border-color: var(--bs-btn-border-color);
--bs-btn-hover-border-color: var(--bs-btn-border-color);
--bs-btn-active-border-color: var(--bs-btn-border-color);

Copilot uses AI. Check for mistakes.
@@ -325,6 +327,7 @@
--bs-btn-disabled-border-color: var(--bs-btn-border-color);
--bs-btn-hover-border-color: #B5B5C3;
--bs-btn-active-border-color: #B5B5C3;
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .btn-outline-light class defines --bs-btn-active-color but is missing the --bs-btn-active-bg property that all other outline button variants have. This creates an inconsistency in the button styling pattern. Either add the missing --bs-btn-active-bg property or document why this button variant should be different.

Suggested change
--bs-btn-active-border-color: #B5B5C3;
--bs-btn-active-border-color: #B5B5C3;
--bs-btn-active-bg: var(--bs-light);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Button): 按钮按下无指示信息

2 participants