Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32793 32793
Branches 4551 4551
=========================================
Hits 32793 32793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds distinct active background colors to button components to provide better visual feedback when buttons are pressed, addressing issue #7402 where users reported difficulty perceiving button press actions during fast operations (particularly for table refresh/search buttons).
Key Changes:
- Replaced generic
var(--bs-btn-hover-bg)values with specific hex colors for--bs-btn-active-bgacross all button color variants - Added
--bs-btn-active-colorproperties for specific outline button variants - Modified border color properties for
.btn-outline-link
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --bs-btn-active-bg: #612ad6; | ||
| --bs-btn-active-color: var(--bs-btn-hover-color); |
There was a problem hiding this comment.
The --bs-btn-active-color property is added for .btn-outline-info but is inconsistently applied across outline button variants. This property should either be added to all outline buttons that need it (secondary, success, warning, danger, dark) or removed if not necessary. Currently, only .btn-outline-info and .btn-outline-light have this property defined, which creates inconsistency in the button styling pattern.
| --bs-btn-active-border-color: var(--bs-btn-border-color); | ||
| --bs-btn-hover-border-color: var(--bs-btn-border-color); |
There was a problem hiding this comment.
The property order appears incorrect for .btn-outline-link. The --bs-btn-hover-border-color property is being redefined after --bs-btn-active-border-color, which breaks the typical CSS custom property declaration order (hover properties should come before active properties). Consider moving line 319 to before line 318 to maintain proper ordering.
| --bs-btn-active-border-color: var(--bs-btn-border-color); | |
| --bs-btn-hover-border-color: var(--bs-btn-border-color); | |
| --bs-btn-hover-border-color: var(--bs-btn-border-color); | |
| --bs-btn-active-border-color: var(--bs-btn-border-color); |
| @@ -325,6 +327,7 @@ | |||
| --bs-btn-disabled-border-color: var(--bs-btn-border-color); | |||
| --bs-btn-hover-border-color: #B5B5C3; | |||
| --bs-btn-active-border-color: #B5B5C3; | |||
There was a problem hiding this comment.
The .btn-outline-light class defines --bs-btn-active-color but is missing the --bs-btn-active-bg property that all other outline button variants have. This creates an inconsistency in the button styling pattern. Either add the missing --bs-btn-active-bg property or document why this button variant should be different.
| --bs-btn-active-border-color: #B5B5C3; | |
| --bs-btn-active-border-color: #B5B5C3; | |
| --bs-btn-active-bg: var(--bs-light); |
Link issues
fixes #7402
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the Motronic theme stylesheet to support an active visual style for buttons.