Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves references to the deprecated admin.blazor.zone / AdminUrl demo from the tutorials and introduction documentation, keeping only the current AdminPro sample and cleaning up related localized strings and links. Flow diagram for Introduction and Admin tutorial pages linking to AdminPro demoflowchart LR
DocsPage_Introduction[/Introduction_page_docs_introduction_components/]
TutorialPage_Admin[/Tutorials_page_admin/]
AdminProDemo["AdminPro_demo_site_(WebsiteOption_AdminProUrl)"]
DocsPage_Introduction -->|AdminPro_link| AdminProDemo
TutorialPage_Admin -->|AdminPro_card_link| AdminProDemo
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
Tutorials/Admin.razor, the second.col-12 col-sm-6column is now empty; consider removing the column or adjusting the layout to avoid rendering unnecessary empty grid elements. - Since the
ShowWebSiteTitle1-related content was removed fromIntroduction.razor, check whether the corresponding localization keys are now unused and can be pruned from the locale JSON files to avoid dead strings.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `Tutorials/Admin.razor`, the second `.col-12 col-sm-6` column is now empty; consider removing the column or adjusting the layout to avoid rendering unnecessary empty grid elements.
- Since the `ShowWebSiteTitle1`-related content was removed from `Introduction.razor`, check whether the corresponding localization keys are now unused and can be pruned from the locale JSON files to avoid dead strings.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Tutorials/Admin.razor:17-16` </location>
<code_context>
</a>
</div>
<div class="col-12 col-sm-6">
- <a href="https://admin.blazor.zone" target="_blank">
- <div class="card">
- <div class="card-header">MVC & Blazor 混合实现</div>
- <div class="card-body">
- <img src="@WebsiteOption.Value.GetAssetUrl("images/tutorials/admin.jpg")" class="w-100" />
- </div>
- </div>
- </a>
</code_context>
<issue_to_address>
**suggestion:** Avoid rendering an empty grid column to prevent awkward layout gaps.
With the inner card/link removed, this column now renders empty on larger screens, leaving an awkward gap. Consider removing this column or updating the grid so the remaining content spans the full width instead of leaving an empty cell.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes references to the admin.blazor.zone sample site (the mixed MVC & Blazor version) from the documentation and demo pages, keeping only the pure Blazor version reference (pro.blazor.zone).
Key Changes
- Removed "ShowWebSiteTitle1" localization entries for the mixed version demo site
- Removed the admin.blazor.zone card display from the Admin tutorial page
- Removed the admin.blazor.zone link from the Introduction page
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Removed Chinese localization entry for "ShowWebSiteTitle1" |
| src/BootstrapBlazor.Server/Locales/en-US.json | Removed English localization entry for "ShowWebSiteTitle1" |
| src/BootstrapBlazor.Server/Components/Samples/Tutorials/Admin.razor | Removed the card section displaying the admin.blazor.zone mixed version demo |
| src/BootstrapBlazor.Server/Components/Pages/Introduction.razor | Removed the paragraph linking to admin.blazor.zone |
| src/BootstrapBlazor.Server/wwwroot/images/tutorials/admin.jpg | Image file deleted (no longer referenced) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
17
to
18
| <div class="col-12 col-sm-6"> | ||
| <a href="https://admin.blazor.zone" target="_blank"> | ||
| <div class="card"> | ||
| <div class="card-header">MVC & Blazor 混合实现</div> | ||
| <div class="card-body"> | ||
| <img src="@WebsiteOption.Value.GetAssetUrl("images/tutorials/admin.jpg")" class="w-100" /> | ||
| </div> | ||
| </div> | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
The empty column div serves no purpose after removing the admin.blazor.zone card. Consider removing this empty column div to maintain cleaner markup, or add content to balance the layout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32798 32798
Branches 4551 4551
=========================================
Hits 32798 32798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7424
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove references to the deprecated admin.blazor.zone sample from the documentation pages.
Documentation: