doc(Table): update ShowMoreButton documentation#7427
Merged
Conversation
Contributor
Reviewer's GuideAdds a dedicated ShowMoreButton demo and documentation to the table column samples, centralizes the MoreButton action handling and toast notification logic in TablesColumn instead of TablesSearch, and updates localization resources accordingly while performing minor formatting cleanups. Sequence diagram for ShowMoreButton dropdown action handlingsequenceDiagram
actor User
participant Browser
participant TablesColumn as TablesColumnComponent
participant Table as TableComponent
participant ToastService
User->>Browser: Click ShowMoreButton
Browser->>Table: Open MoreButtonDropdown
User->>Table: Click DropdownItem with actionName
Table->>TablesColumn: OnAction(contextFoo, actionName)
TablesColumn->>ToastService: Information(foo.Name, "Trigger " + actionName)
ToastService-->>Browser: Render toast notification
Browser-->>User: Display toast with action feedback
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
OnClickattributes in the newMoreButtonDropdownTemplate(e.g.,OnClick="@(() => OnAction(context, "Action1"))") will not compile due to nested double quotes; switch the inner string literals to single quotes or escape the quotes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `OnClick` attributes in the new `MoreButtonDropdownTemplate` (e.g., `OnClick="@(() => OnAction(context, "Action1"))"`) will not compile due to nested double quotes; switch the inner string literals to single quotes or escape the quotes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7427 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32798 32798
Branches 4551 4551
=========================================
Hits 32798 32798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for the Table component's ShowMoreButton feature by introducing a new demo section with bilingual (English and Chinese) documentation.
- Adds localization entries for ShowMoreButton documentation in both zh-CN and en-US locales
- Relocates the MoreButtonDropdownTemplate demo from TablesSearch to TablesColumn component for better organization
- Includes supporting code (ToastService injection and OnAction method) to demonstrate the feature functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Adds Chinese localization strings for ShowMoreButton documentation |
| src/BootstrapBlazor.Server/Locales/en-US.json | Adds English localization strings for ShowMoreButton documentation |
| src/BootstrapBlazor.Server/Components/Samples/Table/TablesSearch.razor.cs | Removes ToastService and OnAction method (relocated to TablesColumn) |
| src/BootstrapBlazor.Server/Components/Samples/Table/TablesSearch.razor | Removes MoreButtonDropdownTemplate demo (relocated to TablesColumn) |
| src/BootstrapBlazor.Server/Components/Samples/Table/TablesColumn.razor.cs | Adds ToastService injection and OnAction method to support the new demo |
| src/BootstrapBlazor.Server/Components/Samples/Table/TablesColumn.razor | Adds comprehensive ShowMoreButton demo section with code examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7426
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Document and demonstrate the table ShowMoreButton dropdown actions in the column samples while cleaning up the search sample.
New Features:
Enhancements: