Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR attempts to update Microsoft.Extensions package dependencies across multiple target frameworks (net6.0, net7.0, net8.0, and net9.0). The changes introduce version upgrades for several Microsoft.Extensions packages including Caching.Memory, Configuration.Json, Http, Hosting.Abstractions, and Options.ConfigurationExtensions.
Key changes:
- For net6.0 and net7.0 targets: Microsoft.Extensions packages upgraded from their respective framework versions to NET8Version (8.0.*)
- For net8.0 and net9.0 targets: Microsoft.Extensions packages upgraded to NET10Version (10.0.0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET6Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Http" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET8Version)" /> |
There was a problem hiding this comment.
Upgrading Microsoft.Extensions packages from NET6Version to NET8Version for a net6.0 target framework creates an inconsistency. While these packages may technically work due to backward compatibility, it's better practice to keep the package versions aligned with the target framework version unless there's a specific reason for the upgrade. This ensures consistency and avoids potential compatibility issues.
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET8Version)" /> | |
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET6Version)" /> |
| <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Localization" Version="$(NET7Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="$(NET7Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Http" Version="$(NET7Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(NET7Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET7Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Http" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(NET8Version)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="$(NET8Version)" /> |
There was a problem hiding this comment.
Upgrading Microsoft.Extensions packages from NET7Version to NET8Version for a net7.0 target framework creates an inconsistency. While these packages may work due to backward compatibility, it's better practice to keep the package versions aligned with the target framework version unless there's a specific reason for the upgrade. This ensures consistency and avoids potential compatibility issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7476 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32922 32922
Branches 4574 4574
=========================================
Hits 32922 32922
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7475
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Build: