Skip to content

fix(EditorForm): GroupName not work #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Jan 23, 2026
Merged

fix(EditorForm): GroupName not work #7568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1015e4a
fix(EditorForm): GroupName not work
ArgoZhang Jan 23, 2026
5dcf7c9
chore: bump version 10.2.3-beta02
ArgoZhang Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.2.3-beta01</Version>
<Version>10.2.3-beta02</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/Components/EditorForm/EditorForm.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public partial class EditorForm<TModel> : IShowLabel, IDisposable

private IEnumerable<KeyValuePair<string, IOrderedEnumerable<IEditorItem>>> GroupItems => RenderItems
.Where(i => !string.IsNullOrEmpty(i.GroupName) && i.IsVisible(ItemChangedType, IsSearch.Value))
.GroupBy(i => i.GroupOrder).OrderBy(i => i.Key)
.GroupBy(i => i.GroupName).OrderBy(i => i.Key)
.Select(i => new KeyValuePair<string, IOrderedEnumerable<IEditorItem>>(i.First().GroupName!, i.OrderBy(x => x.Order)));
Comment on lines +220 to 221
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly changes the grouping from GroupOrder to GroupName, which resolves the issue where items with different GroupNames were being merged. However, groups are now ordered alphabetically by GroupName (the Key) instead of numerically by GroupOrder. This means the GroupOrder property is no longer respected for determining the display order of groups. Consider changing the ordering to respect GroupOrder while maintaining the GroupName grouping. The correct implementation should order groups by their GroupOrder value, not by their name.

Suggested change
.GroupBy(i => i.GroupName).OrderBy(i => i.Key)
.Select(i => new KeyValuePair<string, IOrderedEnumerable<IEditorItem>>(i.First().GroupName!, i.OrderBy(x => x.Order)));
.GroupBy(i => i.GroupName).OrderBy(g => g.Min(x => x.GroupOrder))
.Select(g => new KeyValuePair<string, IOrderedEnumerable<IEditorItem>>(g.First().GroupName!, g.OrderBy(x => x.Order)));

Copilot uses AI. Check for mistakes.

private List<IEditorItem>? _itemsCache;
Expand Down
Loading