Skip to content

fix(Select): placeholder does not disappear #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 3 commits into from
Jan 25, 2026
Merged

fix(Select): placeholder does not disappear #7581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85de8b7
fix: 修复请求数量不正确问题
ArgoZhang Jan 25, 2026
ac5c6dc
chore: bump version 10.2.3
ArgoZhang Jan 25, 2026
12a67fb
chore: bump version 10.2.3
ArgoZhang Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.2.3-beta03</Version>
<Version>10.2.3</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
5 changes: 1 addition & 4 deletions src/BootstrapBlazor/Components/Select/MultiSelect.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,16 +284,13 @@ private List<SelectedItem> GetItemsByVirtualize()

private async ValueTask<ItemsProviderResult<SelectedItem>> LoadItems(ItemsProviderRequest request)
{
var count = !string.IsNullOrEmpty(SearchText) ? request.Count : GetCountByTotal();
var data = await OnQueryAsync(new() { StartIndex = request.StartIndex, Count = count, SearchText = SearchText });
var data = await OnQueryAsync(new() { StartIndex = request.StartIndex, Count = request.Count, SearchText = SearchText });

_itemsCache = null;
_totalCount = data.TotalCount;
var items = data.Items ?? [];
_result = new ItemsProviderResult<SelectedItem>(items, _totalCount);
return _result;

int GetCountByTotal() => _totalCount == 0 ? request.Count : Math.Min(request.Count, _totalCount - request.StartIndex);
}

/// <summary>
Expand Down
5 changes: 1 addition & 4 deletions src/BootstrapBlazor/Components/Select/Select.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,16 +261,13 @@ protected override async Task OnParametersSetAsync()

private async ValueTask<ItemsProviderResult<SelectedItem>> LoadItems(ItemsProviderRequest request)
{
var count = !string.IsNullOrEmpty(SearchText) ? request.Count : GetCountByTotal();
var data = await OnQueryAsync(new() { StartIndex = request.StartIndex, Count = count, SearchText = SearchText });
var data = await OnQueryAsync(new() { StartIndex = request.StartIndex, Count = request.Count, SearchText = SearchText });
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same conditional count logic that was removed here still exists in SelectGeneric.razor.cs (line 318) and MultiSelectGeneric.razor.cs (line 348). If this fix resolves the placeholder issue in Select and MultiSelect, the same fix should be applied to SelectGeneric and MultiSelectGeneric components for consistency and to prevent the same bug from occurring there.

Copilot uses AI. Check for mistakes.

_itemsCache = null;
_totalCount = data.TotalCount;
var items = data.Items ?? [];
_result = new ItemsProviderResult<SelectedItem>(items, _totalCount);
return _result;

int GetCountByTotal() => _totalCount == 0 ? request.Count : Math.Min(request.Count, _totalCount - request.StartIndex);
}

/// <summary>
Expand Down
Loading