Skip to content

doc(Pre): update max-height style #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Feb 25, 2026
Merged

doc(Pre): update max-height style #7723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9f36b
doc: 调整 Pre 组件高度
ArgoZhang Feb 24, 2026
d681db4
Merge branch 'main' into dev-pre
ArgoZhang Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/BootstrapBlazor.Server/Components/Components/DemoBlock.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.card {
.card {
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file now starts without the UTF-8 BOM marker, while most .razor.css files in this project appear to keep the BOM. If the change is unintentional, consider restoring the BOM to keep encoding consistent and reduce churn in diffs.

Copilot uses AI. Check for mistakes.
transition: box-shadow .3s linear;
}

Expand Down Expand Up @@ -48,6 +48,10 @@
width: calc(100% - 1rem);
}

.card-footer-code ::deep pre {
max-height: 260px;
}

.card-footer-control {
text-align: center;
color: #d3dce6;
Expand Down
1 change: 0 additions & 1 deletion src/BootstrapBlazor.Server/Components/Components/Pre.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ public partial class Pre

private string? StyleString => CssBuilder.Default()
.AddClass($"height: {Height};", !string.IsNullOrEmpty(Height))
.AddClass("max-height: 260px;", string.IsNullOrEmpty(Height))
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Removing the default max-height may affect Pre usage outside DemoBlock contexts.

Pre used to enforce max-height: 260px whenever Height was unset, in all contexts. Now that constraint only exists via .card-footer-code ::deep pre in DemoBlock.razor.css, so any other Pre usages without an explicit Height can now expand indefinitely. If that global behavior change isn’t desired, consider retaining a default max-height in Pre and overriding it specifically in DemoBlock instead.

.AddClassFromAttributes(AdditionalAttributes)
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyleString is used for the <pre> element’s style attribute, but it currently calls AddClassFromAttributes(AdditionalAttributes), which pulls the class attribute (not style) and appends it into the style string. This also means any user-provided style in AdditionalAttributes is ignored for the <pre>. Use AddStyleFromAttributes(AdditionalAttributes) here (consistent with other components like Scroll/Affix).

Suggested change
.AddClassFromAttributes(AdditionalAttributes)
.AddStyleFromAttributes(AdditionalAttributes)

Copilot uses AI. Check for mistakes.
.Build();

Expand Down
2 changes: 1 addition & 1 deletion src/BootstrapBlazor.Server/Components/Layout/ComponentLayout.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.bb-title {
.bb-title {
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file now starts without the UTF-8 BOM marker, while most .razor.css files in this project appear to keep the BOM (e.g., many other component/layout scoped CSS files). If the change is unintentional, consider restoring the BOM to avoid inconsistent encoding/noisy diffs across the repo.

Copilot uses AI. Check for mistakes.
font-size: 1.2rem;
display: flex;
justify-content: center;
Expand Down