Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the newly added/relocated
localization/km-KH.json, double-check that the culture name and file path are consistent with how other locale files are referenced inBootstrapBlazor.csprojand consumed at runtime (e.g., same folder, naming pattern, and build action). - In
BootstrapBlazor.csprojand the solution file, keep the locale JSON entries grouped and alphabetically ordered like the existing ones to make future maintenance and additions easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the newly added/relocated `localization/km-KH.json`, double-check that the culture name and file path are consistent with how other locale files are referenced in `BootstrapBlazor.csproj` and consumed at runtime (e.g., same folder, naming pattern, and build action).
- In `BootstrapBlazor.csproj` and the solution file, keep the locale JSON entries grouped and alphabetically ordered like the existing ones to make future maintenance and additions easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request updates localization files for the EditDialog component and releases version 10.3.3 of BootstrapBlazor. The changes add close confirmation dialog strings (CloseConfirmTitle and CloseConfirmContent) to all supported locale files in the /localization directory, bringing them in sync with the reference locale files in src/BootstrapBlazor/Locales/.
Changes:
- Updated version from 10.3.3-beta02 to 10.3.3 (release version)
- Added
CloseConfirmTitleandCloseConfirmContentkeys to 10 locale files (de, es, it, km-KH, pt-BR, pt, ru-RU, th-TH, uk-UA, zh-TW) - Added km-KH.json to the solution file in alphabetical order
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor/BootstrapBlazor.csproj | Version bump from 10.3.3-beta02 to 10.3.3 release |
| localization/zh-TW.json | Added close confirmation dialog strings in Traditional Chinese |
| localization/uk-UA.json | Added close confirmation dialog strings in Ukrainian |
| localization/th-TH.json | Added close confirmation dialog strings in Thai |
| localization/ru-RU.json | Added close confirmation dialog strings in Russian |
| localization/pt.json | Added close confirmation dialog strings in Portuguese |
| localization/pt-BR.json | Added close confirmation dialog strings in Brazilian Portuguese |
| localization/km-KH.json | Added close confirmation dialog strings in Khmer |
| localization/it.json | Added close confirmation dialog strings in Italian |
| localization/es.json | Added close confirmation dialog strings in Spanish |
| localization/de.json | Added close confirmation dialog strings in German |
| BootstrapBlazor.slnx | Added km-KH.json to solution file in correct alphabetical order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 750 750
Lines 33268 33269 +1
Branches 4612 4612
=========================================
+ Hits 33268 33269 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7724
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update localization JSON resources and project references to them.
Enhancements:
Documentation: