Skip to content

feat(SelectSearchMetadata): add ShowSearch parameter #7796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 4 commits into from
Mar 24, 2026
Merged

feat(SelectSearchMetadata): add ShowSearch parameter #7796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f487ff6
feat(SelectSearchMetadata): add ShowSearch parameter
ArgoZhang Mar 23, 2026
615264a
test: 更新单元测试
ArgoZhang Mar 23, 2026
9a7da23
chore: bump version 10.5.0-beta01
ArgoZhang Mar 23, 2026
f5b5af0
Merge branch 'main' into feat-search-item
ArgoZhang Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.4.2</Version>
<Version>10.5.0-beta01</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 6 additions & 0 deletions src/BootstrapBlazor/Components/Searches/SelectSearchMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ namespace BootstrapBlazor.Components;
/// </summary>
public class SelectSearchMetadata : StringSearchMetadata
{
/// <summary>
/// <para lang="zh">获得/设置 是否显示搜索框 默认 false 不显示</para>
/// <para lang="en">Gets or sets a value indicating whether to show the search box. Default is false.</para>
/// </summary>
public bool ShowSearch { get; set; }

/// <summary>
/// <para lang="zh">获得/设置 选择项集合</para>
/// <para lang="en">Gets or sets the collection of select items</para>
Expand Down
1 change: 1 addition & 0 deletions src/BootstrapBlazor/Extensions/ISearchItemExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ private void AddSelectSearchComponent(ISearchItem item, SelectSearchMetadata sel
builder.AddAttribute(60, nameof(Select<>.Items), selectSearchMetadata.Items);
builder.AddAttribute(70, nameof(Select<>.PlaceHolder), selectSearchMetadata.PlaceHolder);
builder.AddAttribute(80, nameof(Select<>.SkipValidate), true);
builder.AddAttribute(90, nameof(Select<>.ShowSearch), selectSearchMetadata.ShowSearch);
builder.CloseComponent();
}

Expand Down
1 change: 1 addition & 0 deletions test/UnitTest/Components/SearchFormItemMetadataTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public void SelectSearchFormItemMetadata_Ok()
{
var meta = new SelectSearchMetadata()
{
ShowSearch = true,
Items = new List<SelectedItem>()
{
Comment on lines 108 to 112
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShowSearch = true is set here but never asserted, so the test doesn't actually validate any behavior change (it only compiles). Consider asserting meta.ShowSearch (at minimum), or moving coverage to a bUnit render test (e.g., in SearchFormTest) that verifies the Select dropdown renders the search input when ShowSearch is enabled.

Copilot uses AI. Check for mistakes.
new SelectedItem("v1", "v1"),
Expand Down
Loading