Use obtain_file to get file for test_cases_step#5162
Open
Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Open
Use obtain_file to get file for test_cases_step#5162Flamefire wants to merge 3 commits intoeasybuilders:developfrom
obtain_file to get file for test_cases_step#5162Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Conversation
boegel
changed the title
obtain_file to get file for test_cases_step
Searching only `source_paths` is inconsistent with how patches etc. are located making it impossible to place tests e.g. next to easyconfigs or in software-specific source folders.
Flamefire
force-pushed
the
obtain-test-cases
branch
from
b71c84d to
7f15da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching only
source_pathsis inconsistent with how patches etc. are located making it impossible to place tests e.g. next to easyconfigs or in software-specific source folders.Also fix some small issues:
RunShellCmdErrorshould be derived fromExceptionnotBaseExceptionRunShellCmdErrorprints some information on invocation when "escaped" I kept theexcept EasyBuildErrorpurposely not catching the formertestsis now reported when not found instead of whatever path was last checked