Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Fixed venv detection on windows, added pyvenv.el detection#137

Open
hexane360 wants to merge 1 commit intoemacs-lsp:masterfrom
hexane360:master
Open

Fixed venv detection on windows, added pyvenv.el detection#137
hexane360 wants to merge 1 commit intoemacs-lsp:masterfrom
hexane360:master

Conversation

@hexane360
Copy link
Copy Markdown

This PR chiefly fixes virtual environment resolution on Windows. I've also added a check for a virtual environment set with pyvenv.el, which overrides any filesystem-based environment detection. Finally, it rewrites lsp-python-ms-locate-python so that it short-circuits once a suitable environment is found.

@hexane360
Copy link
Copy Markdown
Author

Looking through the commit history, it's possible this may cause a regression on issue #122. I'll try do some testing and check that that use-case is still supported. I think it might be time for a complete rewrite of lsp-python-ms--dominating-venv-python and children, but I'm hesitant because I don't know exactly what logic is required for everyone else's usecase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant