fix: migrate baseline generation to @webref/css#419
Open
xbinaryx wants to merge 1 commit intoeslint:mainfrom
Open
fix: migrate baseline generation to @webref/css#419xbinaryx wants to merge 1 commit intoeslint:mainfrom
xbinaryx wants to merge 1 commit intoeslint:mainfrom
Conversation
1 task
|
Changes LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR migrates baseline generation away from the deprecated
mdn-datapackage and over to@webref/css.What changes did you make? (Give an overview)
I updated
tools/generate-baseline.jsto use@webref/cssas the source of known CSS function names. I also replacedmdn-datawith@webref/cssinpackage.json, updated theupdate-baselineworkflow to refresh@webref/cssinstead ofmdn-data, and regenerated the baseline data.During the migration, I also handled the
string()edge case so we do not incorrectly treatcss.types.stringsupport as support for thestring()function.Related Issues
Closes #376
Is there anything you'd like reviewers to focus on?