Skip to content

Fix Windows install security warning from Invoke-WebRequest #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shouze merged 2 commits into from
Mar 29, 2026
+33 −6
Merged

Fix Windows install security warning from Invoke-WebRequest #122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70a50b0
Fix Windows install security warning from Invoke-WebRequest
shouze Mar 29, 2026
47c0dbf
Add curl.exe fallback when GitHub API unreachable for specific version
shouze Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ if ($Version -eq "latest") {
try {
$Response = Invoke-RestMethod -Uri $ApiUrl -Headers @{ "Accept" = "application/vnd.github.v3+json" }
$Tag = $Response.tag_name
$ReleaseAssets = $Response.assets | ForEach-Object { $_.name }
} catch {
Write-Output "Install Failed:"
Write-Output " Could not determine the latest release from the GitHub API."
Expand All @@ -118,6 +119,18 @@ if ($Version -eq "latest") {
}
} else {
$Tag = $Version
$ApiUrl = "https://api.github.com/repos/${Repo}/releases/tags/${Tag}"

try {
$Response = Invoke-RestMethod -Uri $ApiUrl -Headers @{ "Accept" = "application/vnd.github.v3+json" }
$ReleaseAssets = $Response.assets | ForEach-Object { $_.name }
Comment thread
shouze marked this conversation as resolved.
} catch {
Write-Output "Install Failed:"
Write-Output " Could not fetch release ${Tag} from the GitHub API."
Write-Output " URL: $ApiUrl"
Write-Output " $_"
exit 1
}
}

# ── Resolve artifact name with automatic x64 fallback ────────────────────────
Expand All @@ -127,6 +140,10 @@ if ($Version -eq "latest") {
# github-code-search-windows-x64-baseline.exe — compatible with any x86-64 CPU
# github-code-search-windows-x64.exe — legacy alias kept for back-compat
# github-code-search-windows-arm64.exe — ARM64
#
# Artifact availability is checked against the GitHub release asset list already
# fetched above — no extra network request needed, and no Invoke-WebRequest
# which triggers a security warning on Windows PowerShell 5.1.

$CandidateTargets = @($Target)
if ($Target -eq "x64-modern") {
Expand All @@ -139,22 +156,21 @@ if ($Target -eq "x64-modern") {
$Artifact = $null
foreach ($Candidate in $CandidateTargets) {
$CandidateArtifact = "${BinaryName}-windows-${Candidate}.exe"
$CheckUrl = "https://github.com/${Repo}/releases/download/${Tag}/${CandidateArtifact}"
try {
# -UseBasicParsing is removed in PowerShell 6+ (pwsh); omit it for compat.
$Null = Invoke-WebRequest -Uri $CheckUrl -Method Head -ErrorAction Stop
if ($ReleaseAssets -contains $CandidateArtifact) {
$Artifact = $CandidateArtifact
$Target = $Candidate
break
} catch {
Write-Output " Variant windows-${Candidate} not found in release ${Tag}, trying next..."
}
}

if ($null -eq $Artifact) {
$AvailableWindows = $ReleaseAssets | Where-Object { $_ -like "*windows*" }
Write-Output "Install Failed:"
Write-Output " No compatible Windows binary found for ${Tag}."
Write-Output " Tried: $($CandidateTargets -join ', ')"
if ($AvailableWindows) {
Write-Output " Available Windows assets: $($AvailableWindows -join ', ')"
}
exit 1
}

Expand Down
Loading