Only run the release workflow when piper-cut-cl.json changes#4314
Merged
copybara-service[bot] merged 2 commits intogoogle:masterfrom Apr 24, 2026
Merged
Only run the release workflow when piper-cut-cl.json changes#4314copybara-service[bot] merged 2 commits intogoogle:masterfrom
copybara-service[bot] merged 2 commits intogoogle:masterfrom
Conversation
This should remove no-op workflow runs on other commits, like https://github.com/google/closure-compiler/actions/runs/24802669504, while still running on "Bump version for compiler release" commits like https://github.com/google/closure-compiler/actions/runs/24790507715.
hybrist
approved these changes
Apr 24, 2026
|
|
||
| # This workflow is triggered by pushes to the `master` branch. | ||
| # This workflow is triggered by pushes to the `master` branch that modify '.github/piper-cut-cl.json'. | ||
| # It first checks if `.github/piper-cut-cl.json` has been modified in the latest push. |
There was a problem hiding this comment.
I assume we're leaving the check as a ~defense in depth for non-material changes to the file..?
Contributor
Author
There was a problem hiding this comment.
That was my intent, but now that I look at the check, it's not smart enough to distinguish material vs. non-material changes anyway
It just diffs the entire file contents before and after.
I'd imagine we could try and make it smarter but not sure it's worth it, given that I don't think we've seen any problems historically. I just removed the check altogether.
Thanks for pointing this out.
The diff looks for any changes, including whitespace/other-non- release-related changes, so it's not useful now that we only trigger the GitHub action on `piper-cut-cl.json` changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should remove no-op workflow runs on other
commits, like https://github.com/google/closure-compiler/actions/runs/24802669504, while still running on "Bump version for compiler release" commits like https://github.com/google/closure-compiler/actions/runs/24790507715.