Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the slew of deprecations we get when updating the protos due to the setting of dynamic properties on PHP objects. Unfortunately this functionality is very critical for this codebase, and removing it would require significant refactoring.
The only solution to suppressing these errors in the core
google/protobuflibrary is to create copies of those files and maintain them in this repository, and add the#[AllowDynamicProperties]annotation there.This solution might introduce more technical debt than it's worth to suppress a deprecation message. The best solution may be to try and refactor this library so it does not require setting of dynamic properties in the core protobuf classes. At least this PR identifies the classes which are using dynamic properties, so that we can potentially refactor them in the future!