Skip to content

chore: consolidate prettierignore and prettierrc files#7948

Closed
feywind wants to merge 20 commits intomainfrom
feywind-gh4581-prettier
Closed

chore: consolidate prettierignore and prettierrc files#7948
feywind wants to merge 20 commits intomainfrom
feywind-gh4581-prettier

Conversation

@feywind
Copy link
Copy Markdown
Contributor

@feywind feywind commented Apr 2, 2026

@feywind feywind requested review from a team as code owners April 2, 2026 20:05
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2026
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2026
@feywind
Copy link
Copy Markdown
Contributor Author

feywind commented Apr 15, 2026

Remaining errors:

  1. presubmit/units - logging-bunyan has an outstanding issue with punycode:
026-04-15T19:57:36.2128760Z   1) Uncaught error outside test suite:
2026-04-15T19:57:36.2130078Z      Uncaught DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
2026-04-15T19:57:36.2130978Z       at node:punycode:7:10
  1. OwlBot is having issues running the types script in bigquery, and a mismatch between OwlBot's linter and the linter used in-project is causing it to erroneously detect dangling Promises. The types script works fine when run manually, and the linter lines have been overridden for now.

  2. Core presubmit is failing due to the sinon pin error. The issue here is that gax pulls a copy of the latest release of google-cloud-speech and tries to build it; the latest release does not have the sinon pin, so it fails. Ignoring this.

@feywind feywind changed the title chore: consolidate prettierignore and prettierrc files chore: consolidate prettierignore and prettierrc files: autogen libraries Apr 20, 2026
@feywind feywind changed the title chore: consolidate prettierignore and prettierrc files: autogen libraries chore: consolidate prettierignore and prettierrc files Apr 20, 2026
@feywind
Copy link
Copy Markdown
Contributor Author

feywind commented Apr 20, 2026

Split into the two sub-PRs.

@feywind feywind closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-node: move .prettierignore and .prettierrc.js to the repo root

2 participants