Spanner: untangle options vars and traits#8348
Closed
bshaffer wants to merge 1 commit intosnapshot-isolationfrom
Closed
Spanner: untangle options vars and traits#8348bshaffer wants to merge 1 commit intosnapshot-isolationfrom
bshaffer wants to merge 1 commit intosnapshot-isolationfrom
Conversation
- explicitly selecting valid fields - better names for variables - documenting missing options in phpdoc - removing pass-by-reference
Contributor
Author
|
This PR was merged into #7841, and will be less risky to continue there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: