Skip to content
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
ed8fa34
Modify the Operation class to use a gapic client
Hectorhammett Aug 18, 2025
67e8f59
Remove connection classes
Hectorhammett Aug 18, 2025
aee6500
Update the runAggregation method
Hectorhammett Aug 18, 2025
f4848e3
Finish DatastoreClient unit tests
Hectorhammett Aug 29, 2025
38fddcc
Update the OperationTest.php
Hectorhammett Sep 2, 2025
b3e9ada
Finish code changes to comply with Integration tests and keep compati…
Hectorhammett Sep 5, 2025
76b76ee
Fix unit tests for OperationTest
Hectorhammett Sep 8, 2025
3d64343
Fix the TransactionTest unit tests
Hectorhammett Sep 11, 2025
7bbc01f
Fix EntityMapperTest unit tests
Hectorhammett Sep 11, 2025
9269c4a
Fix base64 encoding
Hectorhammett Sep 23, 2025
9ebfdc5
Modify the operation class to use the new validateOptions method
Hectorhammett Sep 29, 2025
6fc1479
Use the validateOptions method to multiple functions inside the Opera…
Hectorhammett Sep 30, 2025
7cb5c4c
Update documentation for Datastore options
Hectorhammett Sep 30, 2025
9b1f5a2
Remove Datastore from the ServiceBuilderTest as this class is depreca…
Hectorhammett Sep 30, 2025
115f604
update Datastore GAPIC V2
bshaffer Sep 24, 2025
f29d7bd
Modify the Operation class to use a gapic client
Hectorhammett Aug 18, 2025
f45fc4b
Remove connection classes
Hectorhammett Aug 18, 2025
ec2505f
Update the runAggregation method
Hectorhammett Aug 18, 2025
421d768
Finish DatastoreClient unit tests
Hectorhammett Aug 29, 2025
a022d66
Update the OperationTest.php
Hectorhammett Sep 2, 2025
917a27a
Finish code changes to comply with Integration tests and keep compati…
Hectorhammett Sep 5, 2025
ae28a19
Fix unit tests for OperationTest
Hectorhammett Sep 8, 2025
4478692
Fix the TransactionTest unit tests
Hectorhammett Sep 11, 2025
1cb5cc8
Fix EntityMapperTest unit tests
Hectorhammett Sep 11, 2025
e21f15b
Fix base64 encoding
Hectorhammett Sep 23, 2025
05f3d9d
Modify the operation class to use the new validateOptions method
Hectorhammett Sep 29, 2025
6680b0b
Use the validateOptions method to multiple functions inside the Opera…
Hectorhammett Sep 30, 2025
a9b9006
Update documentation for Datastore options
Hectorhammett Sep 30, 2025
4b91102
Remove Datastore from the ServiceBuilderTest as this class is depreca…
Hectorhammett Sep 30, 2025
9e0c620
Fix Snippet tests
Hectorhammett Oct 1, 2025
1b33af8
Remove unused connectioType property on EntityMapper
Hectorhammett Oct 1, 2025
030a5b5
Remove the KeyFile option from the configuration options
Hectorhammett Oct 1, 2025
4815ccf
Add support for the emulatore tests
Hectorhammett Oct 2, 2025
7e1e7bd
Fix style issues
Hectorhammett Oct 2, 2025
c52f97f
Fix Type annotation
Hectorhammett Oct 2, 2025
a92786d
Update core dependency
Hectorhammett Oct 2, 2025
ee037bd
Update credentials handling
Hectorhammett Oct 2, 2025
5afea27
Add credentials handling
Hectorhammett Oct 2, 2025
4f4a0ab
Fix style issue
Hectorhammett Oct 2, 2025
74b1459
Add fixture for credentials configuration
Hectorhammett Oct 2, 2025
893d71a
Change logic to use only GRPC values
Hectorhammett Oct 3, 2025
e301e46
Fix style issues
Hectorhammett Oct 3, 2025
70b0bde
Remove unnecessary imports
Hectorhammett Oct 3, 2025
9811fdf
Update core dependency version
Hectorhammett Oct 3, 2025
6b289ee
Merge branch 'datastore-modernization' into datastore-gapic-v2
bshaffer Oct 8, 2025
66c8a7c
Update bootstrap.php
bshaffer Oct 8, 2025
4f9cae3
updates from main
bshaffer Oct 8, 2025
27945a4
Modify the Operation class to use a gapic client
Hectorhammett Aug 18, 2025
265fe7e
Remove connection classes
Hectorhammett Aug 18, 2025
f0fb6bf
Update the runAggregation method
Hectorhammett Aug 18, 2025
98840d1
Finish DatastoreClient unit tests
Hectorhammett Aug 29, 2025
944d176
Update the OperationTest.php
Hectorhammett Sep 2, 2025
a877b57
Finish code changes to comply with Integration tests and keep compati…
Hectorhammett Sep 5, 2025
1d30d9a
Fix unit tests for OperationTest
Hectorhammett Sep 8, 2025
21d6647
Fix the TransactionTest unit tests
Hectorhammett Sep 11, 2025
e35f381
Fix EntityMapperTest unit tests
Hectorhammett Sep 11, 2025
72d0480
Fix base64 encoding
Hectorhammett Sep 23, 2025
61afc53
Modify the operation class to use the new validateOptions method
Hectorhammett Sep 29, 2025
67ee87f
Use the validateOptions method to multiple functions inside the Opera…
Hectorhammett Sep 30, 2025
26d45a7
Update documentation for Datastore options
Hectorhammett Sep 30, 2025
5ca8f5c
Remove Datastore from the ServiceBuilderTest as this class is depreca…
Hectorhammett Sep 30, 2025
797367d
Fix Snippet tests
Hectorhammett Oct 1, 2025
ee09a6e
Remove unused connectioType property on EntityMapper
Hectorhammett Oct 1, 2025
9ee6a54
Remove the KeyFile option from the configuration options
Hectorhammett Oct 1, 2025
1c1ed17
Add support for the emulatore tests
Hectorhammett Oct 2, 2025
fb7f58e
Fix style issues
Hectorhammett Oct 2, 2025
0f7a890
Fix Type annotation
Hectorhammett Oct 2, 2025
5e0e5ff
Update core dependency
Hectorhammett Oct 2, 2025
d881e7b
Update credentials handling
Hectorhammett Oct 2, 2025
7e8827f
Add credentials handling
Hectorhammett Oct 2, 2025
aeddb00
Fix style issue
Hectorhammett Oct 2, 2025
1d357d0
Add fixture for credentials configuration
Hectorhammett Oct 2, 2025
f95d3d6
Change logic to use only GRPC values
Hectorhammett Oct 3, 2025
ab69a78
Fix style issues
Hectorhammett Oct 3, 2025
a7221fb
Remove unnecessary imports
Hectorhammett Oct 3, 2025
75ec383
Update core dependency version
Hectorhammett Oct 3, 2025
78cb9a8
Merge branch 'datastore-gapic-v2' into datastore-modernization
Hectorhammett Oct 8, 2025
1f6e16e
Add the OptionsValidator property to the Operation class
Hectorhammett Oct 8, 2025
103ba8d
Merge branch 'main' into datastore-modernization
bshaffer Oct 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Core/src/ApiHelperTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,12 @@ private function validateOptions(array $options, array|Message|string ...$option
);
$messageOptions = $this->pluckArray($messageKeys, $options);
if ($optionType instanceof Message) {
$optionType->mergeFromJsonString(json_encode($messageOptions, JSON_FORCE_OBJECT));
if (!empty($this->serializer)) {
$optionType = $this->serializer->decodeMessage($optionType, $messageOptions);
} else {
$optionType->mergeFromJsonString(json_encode($messageOptions, JSON_FORCE_OBJECT));
}
Comment thread
bshaffer marked this conversation as resolved.
Outdated

$validatedOptionGroup = $optionType;
} else {
$validatedOptionGroup = $messageOptions;
Expand Down
1 change: 0 additions & 1 deletion Core/tests/Snippet/ServiceBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public function serviceBuilderMethods()
{
return [
['bigQuery', BigQueryClient::class, 'bigQuery'],
['datastore', DatastoreClient::class, 'datastore'],
['firestore', FirestoreClient::class, 'firestore', true],
['logging', LoggingClient::class, 'logging'],
['language', LanguageClient::class, 'language'],
Expand Down
6 changes: 1 addition & 5 deletions Core/tests/Unit/ServiceBuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
use Google\Cloud\Core\ServiceBuilder;
use Google\Cloud\Core\Testing\CheckForClassTrait;
use Google\Cloud\Core\Testing\GrpcTestTrait;
use Google\Cloud\Datastore\DatastoreClient;
use Google\Cloud\Firestore\FirestoreClient;
use Google\Cloud\Language\LanguageClient;
use Google\Cloud\Logging\LoggingClient;
Expand Down Expand Up @@ -147,10 +146,7 @@ public function serviceProvider()
[
'bigQuery',
BigQueryClient::class
], [
'datastore',
DatastoreClient::class
], [
],[
'firestore',
FirestoreClient::class,
[],
Expand Down
5 changes: 3 additions & 2 deletions Datastore/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"minimum-stability": "stable",
"require": {
"php": "^8.1",
"google/cloud-core": "^1.63.0",
"google/cloud-core": "^1.65",
Comment thread
bshaffer marked this conversation as resolved.
Outdated
"google/gax": "^1.38.0"
},
"require-dev": {
Expand All @@ -14,7 +14,8 @@
"squizlabs/php_codesniffer": "2.*",
"phpdocumentor/reflection": "^5.3.3||^6.0",
"phpdocumentor/reflection-docblock": "^5.3",
"erusev/parsedown": "^1.6"
"erusev/parsedown": "^1.6",
"dg/bypass-finals": "^1.9"
},
"extra": {
"component": {
Expand Down
2 changes: 1 addition & 1 deletion Datastore/phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="tests/Unit/bootstrap.php" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<coverage>
<include>
<directory suffix=".php">src</directory>
Expand Down
62 changes: 0 additions & 62 deletions Datastore/src/Connection/ConnectionInterface.php

This file was deleted.

Loading
Loading